Skip to content

ci(dependabot): ignore eslint major upgrades#28

Merged
ronload merged 1 commit into
mainfrom
ci/dependabot-ignore-eslint-major
Apr 24, 2026
Merged

ci(dependabot): ignore eslint major upgrades#28
ronload merged 1 commit into
mainfrom
ci/dependabot-ignore-eslint-major

Conversation

@ronload
Copy link
Copy Markdown
Owner

@ronload ronload commented Apr 24, 2026

Summary

Why

PR #24 failed CI with:

TypeError: Error while loading rule 'react/display-name':
contextOrFilename.getFilename is not a function
  at resolveBasedir (.../eslint-plugin-react/lib/util/version.js:31:100)

eslint-plugin-react@7.37.5 (a transitive dependency of eslint-config-next@16.2.4) is not yet compatible with ESLint 10 — it still calls the pre-10 context.getFilename() API as a function rather than via context.filename. Until the plugin catches up, any ESLint 10 upgrade will break pnpm lint.

Grouping means a single incompatible major bump blocks six otherwise-fine patch/minor bumps. Ignoring major eslint updates keeps the group shippable.

Follow-up

After this merges:

  1. Close build(deps-dev): bump the dev-dependencies group with 7 updates #24 — Dependabot will recreate a clean group PR on the next weekly schedule without the ESLint 10 bump.
  2. Once eslint-plugin-react (or eslint-config-next) ships ESLint 10 support, drop this ignore rule.

Test plan

  • Green CI on this PR (no code change, config-only).
  • After merge, confirm Dependabot's next grouped dev-deps PR stays on ESLint 9.x.

eslint-plugin-react (pulled in transitively via eslint-config-next)
does not yet support ESLint 10.x, which caused the grouped dev-deps
upgrade PR to fail lint with:

  TypeError: Error while loading rule 'react/display-name':
  contextOrFilename.getFilename is not a function

Pin dependabot to patch/minor bumps on eslint until the upstream
plugin catches up, so the rest of the dev-dependencies group can
keep landing.
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
zipkit Ready Ready Preview, Comment Apr 24, 2026 7:37am

@ronload ronload merged commit 2e99c3a into main Apr 24, 2026
3 checks passed
@ronload ronload deleted the ci/dependabot-ignore-eslint-major branch April 24, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant