ci(dependabot): ignore eslint major upgrades#28
Merged
Conversation
eslint-plugin-react (pulled in transitively via eslint-config-next) does not yet support ESLint 10.x, which caused the grouped dev-deps upgrade PR to fail lint with: TypeError: Error while loading rule 'react/display-name': contextOrFilename.getFilename is not a function Pin dependabot to patch/minor bumps on eslint until the upstream plugin catches up, so the rest of the dev-dependencies group can keep landing.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
version-update:semver-majorforeslintin the npm ecosystem.dev-dependenciesPR (build(deps-dev): bump the dev-dependencies group with 7 updates #24), which was trying to pull ESLint from9.39.4to10.2.1.Why
PR #24 failed CI with:
eslint-plugin-react@7.37.5(a transitive dependency ofeslint-config-next@16.2.4) is not yet compatible with ESLint 10 — it still calls the pre-10context.getFilename()API as a function rather than viacontext.filename. Until the plugin catches up, any ESLint 10 upgrade will breakpnpm lint.Grouping means a single incompatible major bump blocks six otherwise-fine patch/minor bumps. Ignoring major eslint updates keeps the group shippable.
Follow-up
After this merges:
eslint-plugin-react(oreslint-config-next) ships ESLint 10 support, drop this ignore rule.Test plan