✨ feat(RepositoryInterfaces): Vague 2 SOLID — FolderRepositoryInterface, UserRepositoryInterface, ShareRepositoryInterface (DIP)#137
Merged
ronan-develop merged 3 commits intomainfrom Mar 16, 2026
Conversation
…oryInterface): créer les 3 interfaces de repository manquantes (SOLID D)
…nter les interfaces de repository + overrides typés (covariance PHP 8)
…les interfaces de repository — DIP respecté
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Objectif
Vague 2 du plan SOLID — ticket
ct-repo-interfaces:Créer les interfaces de repository manquantes pour respecter le Dependency Inversion Principle (SOLID D).
📋 Changements
Nouvelles interfaces (
src/Interface/)FolderRepositoryInterfacefind,findBy,findOneBy,count,findDescendantIds,findAncestorIds,findAllAsTree,searchByNameUserRepositoryInterfacefind,findOneByShareRepositoryInterfacefind,findByUser,countByUser,findActiveShareRepos mis à jour
FolderRepository implements FolderRepositoryInterface+ overrides typés (covariance?Foldervs?object)UserRepository implements UserRepositoryInterface+ overrides typésShareRepository implements ShareRepositoryInterface+ overridefindtypéConsommateurs mis à jour (DIP)
FolderProcessor→FolderRepositoryInterface+UserRepositoryInterfaceAlbumProcessor→UserRepositoryInterfaceShareProcessor→ShareRepositoryInterface+UserRepositoryInterfaceservices.yaml: 3 bindings interface → implémentation✅ Tests
287 tests, 605 assertions — tous passants
🔗 Référence
Plan :
.github/solid.md— Vague 2 (ct-repo-interfaces)