fix: 'zoom to timeline' now scales the timeline to 95% of the viewport - #47
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughChangesTimeline fit behavior
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ronak-create
approved these changes
Aug 4, 2026
ronak-create
left a comment
Owner
There was a problem hiding this comment.
Approving — small, correct, and the comments explain the reasoning.
Two notes for the record rather than changes:
- Dropping
TIMELINE_PAD_SECfrom the fit span is the right call, but sincecontentWidth()still adds it, a horizontal scrollbar will now always be present after a Fit. That matches how Fit behaves in other NLEs, so I read it as intended — just flagging it since the old comment explicitly promised "no horizontal overflow". - The
projDur()hardening (skipping clips whose track is not inTRACKS, guarding non-finite ends) goes a little beyond the title. It is a safe improvement —projDur()also feeds the export duration, and a clip on a nonexistent track is not rendered anyway — so no objection, it just deserves a mention in the description.
Conflicts with none of the other open PRs, so this one goes in first.
This was referenced Aug 4, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
'Zoom to timeline' ( shortcut Z) feature now scales the timeline so that it it fits within 95% of the available space.
Type of change
How was it verified?
node --check server.js && node --check app.js && node --check mcp-server.jspassesCLAUDE.md/README.mdif the schema, props, or API changedChecklist
Summary by CodeRabbit