Skip to content

fix(attw): apply profiles to file-based problems - #1098

Open
rudycelekli wants to merge 1 commit into
rolldown:mainfrom
rudycelekli:fix/attw-profile-internal-resolution
Open

rudycelekli wants to merge 1 commit into
rolldown:mainfrom
rudycelekli:fix/attw-profile-internal-resolution

Conversation

@rudycelekli

Copy link
Copy Markdown

AI usage

  • No AI was used in this PR.
  • AI was used: Codex + GPT-6 (implementation, tests and write-up).
    • I have carefully reviewed the AI-generated content myself.

Description

Apply the selected ATTW resolution profile to file-based problems using their entrypoint visibility. ESM-only packages build successfully when an internal resolution error affects only node10; problems affecting required resolutions remain reported.

Linked Issues

Fixes #1096

Additional context

Seven native CLI tests build and pack actual package fixtures. The pinned base fails three profile cases; all seven pass with the fix, including strict, required CJS/self-subpath failures, warn/error levels and explicit ignored rules. Lint, typecheck and the workspace build pass on Node 24.18.0. Full workspace tests: 539 passed, 4 expected failures, 4 skipped. Independent AI source and native regression review passed. The suite uses an isolated temporary directory so the no-package-manager migration fixture does not inherit the host home lockfile.

Copilot AI balanced review requested due to automatic review settings October 13, 2026 05:39
@netlify

netlify Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for tsdown-main ready!

Name Link
🔨 Latest commit 6d38f13
🔍 Latest deploy log https://app.netlify.com/projects/tsdown-main/deploys/6acdc417df53d88bf573d976
😎 Deploy Preview https://deploy-preview-1098--tsdown-main.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@pkg-pr-new

pkg-pr-new Bot commented Oct 13, 2026

Copy link
Copy Markdown

Open in StackBlitz

tsdown

pnpm add https://pkg.pr.new/rolldown/tsdown@1098 -D
npm i https://pkg.pr.new/rolldown/tsdown@1098 -D
yarn add https://pkg.pr.new/rolldown/tsdown@1098.tgz -D

create-tsdown

pnpm add https://pkg.pr.new/rolldown/tsdown/create-tsdown@1098 -D
npm i https://pkg.pr.new/rolldown/tsdown/create-tsdown@1098 -D
yarn add https://pkg.pr.new/rolldown/tsdown/create-tsdown@1098.tgz -D

@tsdown/css

pnpm add https://pkg.pr.new/rolldown/tsdown/@tsdown/css@1098 -D
npm i https://pkg.pr.new/rolldown/tsdown/@tsdown/css@1098 -D
yarn add https://pkg.pr.new/rolldown/tsdown/@tsdown/css@1098.tgz -D

@tsdown/exe

pnpm add https://pkg.pr.new/rolldown/tsdown/@tsdown/exe@1098 -D
npm i https://pkg.pr.new/rolldown/tsdown/@tsdown/exe@1098 -D
yarn add https://pkg.pr.new/rolldown/tsdown/@tsdown/exe@1098.tgz -D

tsdown-migrate

pnpm add https://pkg.pr.new/rolldown/tsdown/tsdown-migrate@1098 -D
npm i https://pkg.pr.new/rolldown/tsdown/tsdown-migrate@1098 -D
yarn add https://pkg.pr.new/rolldown/tsdown/tsdown-migrate@1098.tgz -D

commit: 6d38f13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The implementation matches ATTW’s resolution visibility semantics and has comprehensive regression coverage.

0 open findings

What changed in this PR

Fixes ATTW profile filtering for file-based resolution problems, resolving #1096.

Changes:

  • Filters file-based problems using entrypoint resolution visibility.
  • Adds seven CLI regression tests across profiles, levels, and ignored rules.
File Description
src/​features/​pkg/​attw.ts Applies profiles to file-based ATTW problems.
tests/​attw.test.ts Adds profile-filtering regression coverage.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

attw: the esm-only profile fails the build on a node10 internal resolution error

2 participants