Repository navigation
fix(attw): apply profiles to file-based problems - #1098
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
✅ Deploy Preview for tsdown-main ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
tsdown
create-tsdown
@tsdown/css
@tsdown/exe
tsdown-migrate
commit: |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The implementation matches ATTW’s resolution visibility semantics and has comprehensive regression coverage.
0 open findings
What changed in this PR
Fixes ATTW profile filtering for file-based resolution problems, resolving #1096.
Changes:
- Filters file-based problems using entrypoint resolution visibility.
- Adds seven CLI regression tests across profiles, levels, and ignored rules.
| File | Description |
|---|---|
src/features/pkg/attw.ts |
Applies profiles to file-based ATTW problems. |
tests/attw.test.ts |
Adds profile-filtering regression coverage. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
1 of 3 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI usage
Description
Apply the selected ATTW resolution profile to file-based problems using their entrypoint visibility. ESM-only packages build successfully when an internal resolution error affects only node10; problems affecting required resolutions remain reported.
Linked Issues
Fixes #1096
Additional context
Seven native CLI tests build and pack actual package fixtures. The pinned base fails three profile cases; all seven pass with the fix, including strict, required CJS/self-subpath failures, warn/error levels and explicit ignored rules. Lint, typecheck and the workspace build pass on Node 24.18.0. Full workspace tests: 539 passed, 4 expected failures, 4 skipped. Independent AI source and native regression review passed. The suite uses an isolated temporary directory so the no-package-manager migration fixture does not inherit the host home lockfile.