Skip to content

perf(dev/lazy): fetch a lazy route in one request (reland #10789) - #11000

Draft
h-a-n-a wants to merge 1 commit into
mainfrom
revert-revert-lazy-one-request
Draft

h-a-n-a wants to merge 1 commit into
mainfrom
revert-revert-lazy-one-request

Conversation

@h-a-n-a

@h-a-n-a h-a-n-a commented Sep 25, 2026 •

Copy link
Copy Markdown
Member

Relands #10789, which #10982 reverted.

#10982 was a temporary revert for vitejs/vite#23547. The Vite fix, vitejs/vite#23568, has now landed: Vite serves the dev runtime from the installed rolldown, instead of a copy built into Vite.

Release note: pair with the next Vite release

This change needs a Vite version that includes vitejs/vite#23568. With older Vite, experimental.bundledDev breaks on every dynamic import:

TypeError: __rolldown_runtime__.requestLazy is not a function

Why older Vite breaks:

  • Older Vite (8.3.1 and earlier) has its own copy of the rolldown dev runtime. That copy has no requestLazy.
  • Older Vite depends on rolldown with a ~ range (~1.2.9 in 8.3.1, ~1.2.6 in 8.3.0). A ~ range accepts new patch versions.
  • So if this ships in a 1.2.x patch, a fresh install of the current Vite gets this rolldown and breaks.

To avoid that, this should ship in a minor release (1.3.0), which ~1.2.x ranges do not pick up. Then the next Vite can move to ~1.3.0 together with vitejs/vite#23568.

🤖 Generated with Claude Code

h-a-n-a commented Sep 25, 2026 •

Copy link
Copy Markdown
Member Author

How to use the Graphite Merge Queue

Add the label graphite: merge-when-ready to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify

netlify Bot commented Sep 25, 2026

Copy link
Copy Markdown

✅ Deploy Preview for rolldown-rs ready!

Name Link
🔨 Latest commit 38ce903
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/6ab65c72aa22bb00087be699
😎 Deploy Preview https://deploy-preview-11000--rolldown-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://revert-revert-lazy-one-request-rolldown-rs.voidzero-docs.workers.dev (commit 38ce903)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://33489dd8-rolldown-rs.voidzero-docs.workers.dev 38ce903 2026-09-25T11:37:07.266Z Visit the dashboard ↗

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant