Repository navigation
fix(mcp): slots flag guard, error detail, and dropped tool params #894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,7 +43,7 @@ agentmemory exposes 54 MCP tools. 8 are in the lean core set (`--tools core` or | |
| | `memory_save` | yes | `content`*: string, `type`: string, `concepts`: string, `files`: string, `project`: string, `agentId`: string | Explicitly save an important insight, decision, or pattern to long-term memory. | | ||
| | `memory_sentinel_create` | | `name`*: string, `type`*: string, `config`: string, `linkedActionIds`: string, `expiresInMs`: number | Create an event-driven sentinel that watches for conditions (webhook, timer, threshold, pattern, approval) and auto-unblocks gated actions when triggered. | | ||
| | `memory_sentinel_trigger` | | `sentinelId`*: string, `result`: string | Externally fire a sentinel, providing an optional result payload. Unblocks any gated actions. | | ||
| | `memory_sessions` | yes | none | List recent sessions with their status and observation counts. | | ||
| | `memory_sessions` | yes | `limit`: number | List recent sessions with their status and observation counts. | | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win Document the The runtime defaults 🤖 Prompt for AI Agents |
||
| | `memory_signal_read` | | `agentId`*: string, `unreadOnly`: string, `threadId`: string, `limit`: number | Read messages for an agent. Marks delivered messages as read. | | ||
| | `memory_signal_send` | | `from`*: string, `to`: string, `content`*: string, `type`: string, `replyTo`: string | Send a message to another agent or broadcast. Supports threading, typed messages, and TTL expiration. | | ||
| | `memory_sketch_create` | | `title`*: string, `description`: string, `expiresInMs`: number, `project`: string | Create an ephemeral action graph for exploratory work. Auto-expires after TTL. Can be promoted to permanent actions or discarded. | | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -271,6 +271,8 @@ async function handleLocal( | |
| content: v.content, | ||
| concepts: v.concepts, | ||
| files: v.files, | ||
| ...(v.project !== undefined && { project: v.project }), | ||
| ...(v.agentId !== undefined && { agentId: v.agentId }), | ||
|
Comment on lines
+274
to
+275
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 📐 Maintainability & Code Quality | 🟠 Major | 🏗️ Heavy lift Do not extend local These lines add agent-scoped data to the in-process fallback store. Route this save path through iii-engine primitives, or remove the local persistence path. As per coding guidelines, 🤖 Prompt for AI AgentsSource: Coding guidelines |
||
| createdAt: isoNow, | ||
| updatedAt: isoNow, | ||
| strength: 7, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
Document array inputs for
memory_save.memory_saveaccepts array-typedconceptsandfiles, but this table lists both parameters asstring. Document both as acceptingstring | string[]to match the runtime contract.Update the registry source and regenerate this file.
🤖 Prompt for AI Agents