Skip to content

feat: upgrade MiniMax default model to M3#818

Open
octo-patch wants to merge 1 commit into
rohitg00:mainfrom
octo-patch:feature/upgrade-minimax-m3
Open

feat: upgrade MiniMax default model to M3#818
octo-patch wants to merge 1 commit into
rohitg00:mainfrom
octo-patch:feature/upgrade-minimax-m3

Conversation

@octo-patch
Copy link
Copy Markdown

@octo-patch octo-patch commented Jun 4, 2026

Summary

Upgrade the default MiniMax model from MiniMax-M2.7 to MiniMax-M3 so agentmemory benefits from the latest MiniMax release out of the box. MiniMax-M2.7 and MiniMax-M2.7-highspeed remain fully supported via MINIMAX_MODEL.

MiniMax-M3 features:

  • 512K context window
  • Up to 128K max output tokens
  • Image input support (Anthropic-compatible side as well)

Changes

  • src/config.ts — default model fallback in detectProvider() is now MiniMax-M3
  • src/providers/index.tsdefaultModelFor("minimax") returns MiniMax-M3
  • src/providers/minimax.ts — docstring updated; explicit mention that M2.7 / M2.7-highspeed remain supported alternatives
  • src/cli/onboarding.ts — provider picker label updated to MiniMax — MiniMax-M3
  • .env.example — sample MINIMAX_MODEL value bumped to MiniMax-M3
  • test/minimax-provider.test.ts, test/fetch-timeout.test.ts, test/fallback-model-resolution.test.ts — model strings updated and assertion for minimax default model bumped to MiniMax-M3

Backwards compatibility

  • Existing users who explicitly set MINIMAX_MODEL=MiniMax-M2.7 (or MiniMax-M2.7-highspeed) are unaffected — only the default changes.
  • No env vars, function signatures, or public APIs are modified.

Testing

npm test -- --run test/minimax-provider.test.ts test/fetch-timeout.test.ts test/fallback-model-resolution.test.ts
# Test Files  3 passed (3)
#      Tests  26 passed (26)

Summary by CodeRabbit

  • Chores

    • Updated default MiniMax LLM model from M2.7 to M3 across configuration and provider defaults.
  • Documentation

    • Enhanced MiniMax provider documentation with updated model version details.
  • Tests

    • Updated test cases to reflect new default model.

- Set MiniMax-M3 as default in src/config.ts and src/providers/index.ts
- Update onboarding label to MiniMax-M3
- Update .env.example sample to MINIMAX_MODEL=MiniMax-M3
- Keep MiniMax-M2.7 and MiniMax-M2.7-highspeed as supported alternatives
- Refresh provider docstring to describe M3 support (up to 128K output)
- Update unit tests to use MiniMax-M3

Signed-off-by: octo-patch <octo-patch@github.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 4, 2026

Someone is attempting to deploy a commit to the rohitg00's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 4, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

This PR updates the default MiniMax LLM model from MiniMax-M2.7 to MiniMax-M3 across environment configuration, CLI onboarding labels, provider initialization defaults, provider documentation, and all related test fixtures to maintain consistency.

Changes

MiniMax Model Version Update

Layer / File(s) Summary
Default model in configuration and provider initialization
.env.example, src/cli/onboarding.ts, src/config.ts, src/providers/index.ts
Environment example, CLI provider label, and provider fallback defaults are updated to use MiniMax-M3 instead of MiniMax-M2.7 when the model is not explicitly set.
Provider documentation and test coverage
src/providers/minimax.ts, test/fallback-model-resolution.test.ts, test/fetch-timeout.test.ts, test/minimax-provider.test.ts
Provider environment variable documentation describes the MiniMax-M3 default and differentiates token limits between M3 (128K) and M2.7 (≤800), and all test fixtures are updated to instantiate MinimaxProvider with the new model version.

🎯 1 (Trivial) | ⏱️ ~3 minutes

🐰 A whisker-twitch of tiny tweaks,
All across your config peaks,
From M2.7 to M3 we go,
Consistent defaults now in flow,
The tests hop along, all in tow! 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat: upgrade MiniMax default model to M3' clearly and concisely describes the main change across all modified files: updating the default MiniMax model from M2.7 to M3 throughout the codebase.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/providers/minimax.ts`:
- Line 14: Update the docblock in src/providers/minimax.ts that documents
MAX_TOKENS so the default shown matches runtime/config defaults (4096); change
the text "MAX_TOKENS — max output tokens (default: 800; ...)" to "MAX_TOKENS —
max output tokens (default: 4096; MiniMax-M2.7 needs ≤800, MiniMax-M3 supports
up to 128K)" so it aligns with src/config.ts and .env.example.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2d40a252-9704-43b3-84ed-3cc3bfe2941f

📥 Commits

Reviewing files that changed from the base of the PR and between 334e5ad and d5b66f1.

📒 Files selected for processing (8)
  • .env.example
  • src/cli/onboarding.ts
  • src/config.ts
  • src/providers/index.ts
  • src/providers/minimax.ts
  • test/fallback-model-resolution.test.ts
  • test/fetch-timeout.test.ts
  • test/minimax-provider.test.ts

Comment thread src/providers/minimax.ts
* MINIMAX_MODEL — model name (default: MiniMax-M2.7)
* MAX_TOKENS — max output tokens (default: 800; MiniMax-M2.7 needs ≤800)
* MINIMAX_MODEL — model name (default: MiniMax-M3; MiniMax-M2.7 / MiniMax-M2.7-highspeed also supported)
* MAX_TOKENS — max output tokens (default: 800; MiniMax-M2.7 needs ≤800, MiniMax-M3 supports up to 128K)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix the MAX_TOKENS default in the provider docblock.

Line 14 says default is 800, but runtime/config defaults are 4096 (see src/config.ts and .env.example). This can mislead operators during setup.

Proposed patch
- *   MAX_TOKENS       — max output tokens (default: 800; MiniMax-M2.7 needs ≤800, MiniMax-M3 supports up to 128K)
+ *   MAX_TOKENS       — max output tokens (default: 4096; MiniMax-M2.7 needs ≤800, MiniMax-M3 supports up to 128K)
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
* MAX_TOKENS max output tokens (default: 800; MiniMax-M2.7 needs ≤800, MiniMax-M3 supports up to 128K)
* MAX_TOKENS max output tokens (default: 4096; MiniMax-M2.7 needs ≤800, MiniMax-M3 supports up to 128K)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/providers/minimax.ts` at line 14, Update the docblock in
src/providers/minimax.ts that documents MAX_TOKENS so the default shown matches
runtime/config defaults (4096); change the text "MAX_TOKENS — max output tokens
(default: 800; ...)" to "MAX_TOKENS — max output tokens (default: 4096;
MiniMax-M2.7 needs ≤800, MiniMax-M3 supports up to 128K)" so it aligns with
src/config.ts and .env.example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant