feat: upgrade MiniMax default model to M3#818
Conversation
- Set MiniMax-M3 as default in src/config.ts and src/providers/index.ts - Update onboarding label to MiniMax-M3 - Update .env.example sample to MINIMAX_MODEL=MiniMax-M3 - Keep MiniMax-M2.7 and MiniMax-M2.7-highspeed as supported alternatives - Refresh provider docstring to describe M3 support (up to 128K output) - Update unit tests to use MiniMax-M3 Signed-off-by: octo-patch <octo-patch@github.com>
|
Someone is attempting to deploy a commit to the rohitg00's projects Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughThis PR updates the default MiniMax LLM model from ChangesMiniMax Model Version Update
🎯 1 (Trivial) | ⏱️ ~3 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/providers/minimax.ts`:
- Line 14: Update the docblock in src/providers/minimax.ts that documents
MAX_TOKENS so the default shown matches runtime/config defaults (4096); change
the text "MAX_TOKENS — max output tokens (default: 800; ...)" to "MAX_TOKENS —
max output tokens (default: 4096; MiniMax-M2.7 needs ≤800, MiniMax-M3 supports
up to 128K)" so it aligns with src/config.ts and .env.example.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 2d40a252-9704-43b3-84ed-3cc3bfe2941f
📒 Files selected for processing (8)
.env.examplesrc/cli/onboarding.tssrc/config.tssrc/providers/index.tssrc/providers/minimax.tstest/fallback-model-resolution.test.tstest/fetch-timeout.test.tstest/minimax-provider.test.ts
| * MINIMAX_MODEL — model name (default: MiniMax-M2.7) | ||
| * MAX_TOKENS — max output tokens (default: 800; MiniMax-M2.7 needs ≤800) | ||
| * MINIMAX_MODEL — model name (default: MiniMax-M3; MiniMax-M2.7 / MiniMax-M2.7-highspeed also supported) | ||
| * MAX_TOKENS — max output tokens (default: 800; MiniMax-M2.7 needs ≤800, MiniMax-M3 supports up to 128K) |
There was a problem hiding this comment.
Fix the MAX_TOKENS default in the provider docblock.
Line 14 says default is 800, but runtime/config defaults are 4096 (see src/config.ts and .env.example). This can mislead operators during setup.
Proposed patch
- * MAX_TOKENS — max output tokens (default: 800; MiniMax-M2.7 needs ≤800, MiniMax-M3 supports up to 128K)
+ * MAX_TOKENS — max output tokens (default: 4096; MiniMax-M2.7 needs ≤800, MiniMax-M3 supports up to 128K)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| * MAX_TOKENS — max output tokens (default: 800; MiniMax-M2.7 needs ≤800, MiniMax-M3 supports up to 128K) | |
| * MAX_TOKENS — max output tokens (default: 4096; MiniMax-M2.7 needs ≤800, MiniMax-M3 supports up to 128K) |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@src/providers/minimax.ts` at line 14, Update the docblock in
src/providers/minimax.ts that documents MAX_TOKENS so the default shown matches
runtime/config defaults (4096); change the text "MAX_TOKENS — max output tokens
(default: 800; ...)" to "MAX_TOKENS — max output tokens (default: 4096;
MiniMax-M2.7 needs ≤800, MiniMax-M3 supports up to 128K)" so it aligns with
src/config.ts and .env.example.
Summary
Upgrade the default MiniMax model from
MiniMax-M2.7toMiniMax-M3so agentmemory benefits from the latest MiniMax release out of the box.MiniMax-M2.7andMiniMax-M2.7-highspeedremain fully supported viaMINIMAX_MODEL.MiniMax-M3features:Changes
src/config.ts— default model fallback indetectProvider()is nowMiniMax-M3src/providers/index.ts—defaultModelFor("minimax")returnsMiniMax-M3src/providers/minimax.ts— docstring updated; explicit mention that M2.7 / M2.7-highspeed remain supported alternativessrc/cli/onboarding.ts— provider picker label updated toMiniMax — MiniMax-M3.env.example— sampleMINIMAX_MODELvalue bumped toMiniMax-M3test/minimax-provider.test.ts,test/fetch-timeout.test.ts,test/fallback-model-resolution.test.ts— model strings updated and assertion for minimax default model bumped toMiniMax-M3Backwards compatibility
MINIMAX_MODEL=MiniMax-M2.7(orMiniMax-M2.7-highspeed) are unaffected — only the default changes.Testing
Summary by CodeRabbit
Chores
Documentation
Tests