Skip to content

fix: prefer embedding API key for OpenAI embeddings #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FrankZ20 wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −1
Open

fix: prefer embedding API key for OpenAI embeddings #802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/providers/embedding/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,11 @@ export function createEmbeddingProvider(): EmbeddingProvider | null {
case "gemini":
return withDimensionGuard(new GeminiEmbeddingProvider(getEnvVar("GEMINI_API_KEY")!));
case "openai":
return withDimensionGuard(new OpenAIEmbeddingProvider(getEnvVar("OPENAI_API_KEY")!));
return withDimensionGuard(
new OpenAIEmbeddingProvider(
getEnvVar("OPENAI_EMBEDDING_API_KEY") || getEnvVar("OPENAI_API_KEY")!,
),
);
case "voyage":
return withDimensionGuard(new VoyageEmbeddingProvider(getEnvVar("VOYAGE_API_KEY")!));
case "cohere":
Expand Down
17 changes: 17 additions & 0 deletions test/embedding-provider.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,23 @@ describe("createEmbeddingProvider", () => {
expect(provider!.name).toBe("openai");
});

it("passes OPENAI_EMBEDDING_API_KEY to OpenAIEmbeddingProvider when set", async () => {
process.env["OPENAI_API_KEY"] = "text-llm-key";
process.env["OPENAI_EMBEDDING_API_KEY"] = "embedding-key";
const provider = createEmbeddingProvider();

const fetchSpy = vi.spyOn(globalThis, "fetch").mockResolvedValue(
new Response(JSON.stringify({ data: [{ embedding: new Array(1536).fill(0.1) }] }), { status: 200 }),
);

await provider!.embed("hello");
expect(fetchSpy.mock.calls[0][1]?.headers).toMatchObject({
Authorization: "Bearer embedding-key",
});

fetchSpy.mockRestore();
});

it("EMBEDDING_PROVIDER override takes precedence", () => {
process.env["GEMINI_API_KEY"] = "test-key-123";
process.env["OPENAI_API_KEY"] = "test-key-456";
Expand Down