Repository navigation
docs: sync README, reliability docs and pipeline diagram with recent merges #1813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| # Recovering failed observation compression | ||
|
|
||
| LLM compression is optional. With `AGENTMEMORY_AUTO_COMPRESS=true`, capture first stores a searchable synthetic observation with privacy-filtered source. A provider error, invalid response or interrupted worker leaves that observation available for search and records a pending or failed compression state. Capture acknowledgement means the observation was stored; it does not mean model compression succeeded. | ||
| LLM compression is optional. With `AGENTMEMORY_AUTO_COMPRESS=true`, capture first stores a searchable synthetic observation with privacy-filtered source. If no usable source remains, capture skips model compression and does not mark the observation pending. A provider error, invalid response or interrupted worker leaves that observation available for search and records a pending or failed compression state. Capture acknowledgement means the observation was stored; it does not mean model compression succeeded. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Clear the pending marker when rebudgeting removes the observation source.
Suggested fix
|
||
|
|
||
| Inspect a session before retrying: | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -4,7 +4,7 @@ Hybrid search allows 500 ms for optional graph enrichment after keyword and vect | |||||
|
|
||||||
| Cancellation prevents additional graph work after the request expires. Name, character, observation and adjacency postings avoid listing canonical graph scopes. Every request checks the active generation and index revision before returning graph evidence. Pending writes, import, mesh updates, reset or restore invalidate an in-flight view. Optional model context contains only titles of current observations authorized for the requested scope; graph properties and intermediate labels do not become model evidence. | ||||||
|
|
||||||
| The graph view returns at most 500 nodes and uses a separate budget of 2,048 reads and 4 MiB. Default pages follow indexed inventory order, not a global degree ranking. Filtered counts describe examined records when the response is truncated. Temporal and graph-node lookups also report partial results when their budgets or projection limits are reached. Graph statistics use maintained index counts; an unavailable index reports unknown counts rather than an empty graph. | ||||||
| The graph view returns at most 500 nodes and uses a separate budget of 2,048 reads and 4 MiB. If its byte budget is exhausted, it retains already collected nodes and edges with `truncated: true`, provided the final generation and revision checks still succeed. A changed index discards those results and returns a retry warning. Default pages follow indexed inventory order, not a global degree ranking. Filtered counts describe examined records when the response is truncated. Temporal and graph-node lookups also report partial results when their budgets or projection limits are reached. Graph statistics use maintained index counts; an unavailable index reports unknown counts rather than an empty graph. | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Document every final check that can discard partial graph results. The sentence says partial results survive when the generation and revision still match. The code also discards them when a write is pending, the index is not Suggested doc update
Committable suggestion
|
||||||
|
|
||||||
| Existing stores require an [explicit legacy migration](graph-index-migration.md). Its initial discovery still reads complete scopes because the pinned engine cannot paginate them. Startup, indexed search, graph views, graph-node lookup and server status never start that scan, and automatic legacy boot compaction is deferred. Explicit maintenance, export, mesh push and snapshot creation remain bulk operations. The standalone MCP graph-stats resource still enumerates canonical graph scopes and requires a separate update; the bounded server graph-stats function does not. The index adds write and storage overhead, so a large migration needs a maintenance window and disk capacity. | ||||||
|
|
||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 Missing required commit sign-off
Commit
c84d0d7lacks aSigned-off-bytrailer. The DCO rules require one on every commit and block merging without it.Devin left this for you to triage: Commit c84d0d7 is authored as Rohit and lacks a DCO Signed-off-by, so the PR can't merge. Adding it needs a history rewrite and force-push (CONTRIBUTING forbids force-pushing) and is a legal attestation in Rohit's name, so Rohit should add it (e.g.
git commit --amend -s) or waive DCO when squash-merging.Was this helpful? React with 👍 or 👎 to provide feedback.