Repository navigation
fix(cli): avoid duplicating env-file values in Compose YAML - #1769
Conversation
Use existing environment-origin tracking to keep file-only values in the selected env file instead of repeating them as explicit worker overrides. Preserve current shell and CLI overrides, including --tools changes made after hydration, and retain the full effective environment for derived state and PATH settings. Add CLI regressions for file-only values, equal and different shell overrides, missing env files and CLI tool-selection precedence. Signed-off-by: zack-dev-cm <112114097+zack-dev-cm@users.noreply.github.com>
|
@zack-dev-cm is attempting to deploy a commit to the rohitg00's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
Fixes #1764.
The CLI now uses the existing env-origin tracker to omit file-only values from its allowlisted worker environment entries. The filtered env file still supplies those values. Current shell and CLI overrides, including --tools changes after hydration, keep their precedence. The full hydrated environment still configures the state-save interval and Windows PATH.
Five subprocess regressions exercise the actual CLI, YAML I/O and worker hydration with a stubbed engine and synthetic values. Unchanged main fails three cases; the patch passes all five.
Validation:
Summary by CodeRabbit
--toolsoption continues to override conflicting environment values.