Repository navigation
Conversation
|
@reevesc88 is attempting to deploy a commit to the rohitg00's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Caution Review failedThe pull request is closed. Walkthrough
Merge Risk:
|
|
Addressed by replacement PR #1723, signed-off commit 2859ef5. Its source tree is identical to 5633bdd (verified with git diff --exit-code), and the full checks pass: 4,774 tests passed, seven skipped, plus build, skills/docs checks and typecheck. The original commit and branch are preserved. This PR is superseded; no history was rewritten or force-pushed. |
A project-filtered recall currently reads the session store even when a durable memory already carries the matching project. If that unnecessary read fails, recall rejects instead of returning the matching memory.
Read session metadata only when a directory filter needs it or project ownership must be established through the session. Preserve directory matching and fail-closed legacy ownership checks. Also assert that the failed-refill regression actually calls the ranker twice.
Addresses both follow-ups in #1647 (review). The original PR is already merged; this is a separate, small follow-up based on current main.
Validation:
The live-server integration test and seven skipped tests were not run. Both historical Actions failures on #1647 were approval expirations, not executed test failures: GitHub reports that the workflow required approval but expired first. Rerun attempts require upstream repository admin rights. A maintainer may need to approve hosted checks on this follow-up too.
Summary by CodeRabbit