Repository navigation
fix: preserve original memory types in search responses - #1646
Conversation
Signed-off-by: reevesc88 <calum@ai1auslutions.com>
|
@reevesc88 is attempting to deploy a commit to the rohitg00's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Caution Review failedThe pull request is closed. Walkthrough
Merge Risk:
|
…n fallback type - A rejected read of the stored memory while building compact results rejected the whole smart-search call. The read now falls back to the memoryType already on the ranked observation. - Standalone fallback compact results now report type "decision", the same as daemon results, with the saved category in memoryType.
Saving a memory with
type: "fact"returns that type, but search currently exposes onlytype: "decision"after converting the memory into an observation. Clients therefore lose the original memory category when they recall or expand the same ID.This adds optional
memoryType: Memory["type"]metadata while keeping the observationtypeenum unchanged. Compact smart search and expanded results preserve the saved category. Recall retains it in full, compact and narrative formats, including budget-clipped previews. Compact smart search reads the already-authorized durable row so existing indexes work without a migration. The standalone fallback adds the same metadata while retaining its existing compact response fields.Regression coverage exercises all six memory types, legacy index results, compact and expanded search, recall clipping, ordinary observations and lessons, standalone fallback, and project/agent boundaries.
docs/recall.mddocuments the response contract. The generated test-count updates are included as required byAGENTS.md.Validation on base
c6c476d2905926727fa5848a134d7a3b38a7fa98:npm run buildnpm run skills:gennpm run docs:syncnpm run skills:checknpm test -- --maxWorkers=4: 4,118 passed, six skippednpm run docs:checkgit diff --checkThe dependency audit reports nine moderate findings in the unchanged dependency graph. This PR does not change dependencies. The live-server integration test and skipped unit cases were not run.
Summary by CodeRabbit