Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/providers/circuit-breaker.ts

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Two commits lack required sign-offs

Commits 0030609a and e8977fa4 lack the Signed-off-by trailer required for every commit. The repository's DCO policy blocks merging them without sign-offs.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,11 @@ export class CircuitBreaker {
}

recordSuccess(): void {
if (this.state === "half-open") {
this.state = "closed";
this.failures = 0;
this.lastFailureAt = null;
this.openedAt = null;
}
if (this.state === "open") return;
this.state = "closed";
this.failures = 0;
this.lastFailureAt = null;
this.openedAt = null;
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Resolved
}

recordFailure(): void {
Expand Down
61 changes: 61 additions & 0 deletions test/circuit-breaker.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -127,4 +127,65 @@ describe("CircuitBreaker", () => {
expect(cb.getState().state).toBe("closed");
expect(cb.getState().failures).toBe(0);
});

it("a success in closed state clears the accumulated failure count", () => {
const cb = new CircuitBreaker();
cb.recordFailure();
cb.recordFailure();
expect(cb.getState().failures).toBe(2);
cb.recordSuccess();
expect(cb.getState().failures).toBe(0);
expect(cb.getState().lastFailureAt).toBeNull();
});

it("stays closed across 100 calls at a 5% failure rate", () => {
const cb = new CircuitBreaker();
for (let i = 0; i < 100; i++) {
if (i % 20 === 0) cb.recordFailure();
else cb.recordSuccess();
vi.advanceTimersByTime(1_000);
expect(cb.getState().state).toBe("closed");
}
expect(cb.isAllowed).toBe(true);
});

it("stays closed when failures are interleaved with successes inside the window", () => {
const cb = new CircuitBreaker();
for (let i = 0; i < 5; i++) {
cb.recordFailure();
cb.recordSuccess();
}
expect(cb.getState().state).toBe("closed");
expect(cb.getState().failures).toBe(0);
});

it("keeps openedAt when a success arrives while open", () => {
const cb = new CircuitBreaker();
cb.recordFailure();
cb.recordFailure();
cb.recordFailure();
expect(cb.getState().state).toBe("open");
const openedAt = cb.getState().openedAt;

cb.recordSuccess();

expect(cb.getState().state).toBe("open");
expect(cb.getState().openedAt).toBe(openedAt);
expect(cb.isAllowed).toBe(false);

vi.advanceTimersByTime(30_000);
expect(cb.isAllowed).toBe(true);
expect(cb.getState().state).toBe("half-open");
});

it("still opens after consecutive failures with no success between them", () => {
const cb = new CircuitBreaker();
cb.recordSuccess();
for (let i = 0; i < 3; i++) {
cb.recordFailure();
vi.advanceTimersByTime(1_000);
}
expect(cb.getState().state).toBe("open");
expect(cb.isAllowed).toBe(false);
});
});