Repository navigation
perf(state): write only the vector buckets that changed #1258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a0b0a0a
perf(state): write only the vector buckets that changed
inix-x faf223a
fix(state): compare the addressing scheme, not just bucket contents
inix-x 03d2dbe
fix(state): address vector buckets by content so a torn save loses no…
inix-x 905be67
fix(state): a failed read is not an empty store, and a clear is not a…
inix-x 0c93c33
fix(state): bump the layout version the key-format change required
inix-x bf325f6
fix(state): refuse to publish a vector bucket the loader will reject
inix-x 99db501
test: hoist the duplicated seeded() vector helper
inix-x 5a1edc7
fix(state): report a vector load that rejected every bucket it read
inix-x ad38fb6
fix(state): accept a bucket hashed by any scheme this format has publ…
inix-x bf21c2d
fix(state): publish vector bucket hashes as sha256
inix-x File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
The rejected-vector rebuild path skips the memory backfill.
The
#257memory backfill lives in theelsebranch ofif (needsRebuild). Before this change, a store with a non-empty restored BM25 index always reached that branch. Now a store whose BM25 restored fine but whose vector buckets were all rejected takes the rebuild branch instead, so the backfill does not run.rebuildIndex(kv)walks observations. Memories are the case the backfill exists for, somemory_smart_searchstays empty for legacymemory_saveentries until a boot without the rejection signal.Gate the backfill on its own condition rather than on the rebuild branch.
🐛 Proposed fix: decouple the backfill from the rebuild branch
Then run the backfill whenever BM25 holds documents, independent of
needsRebuild:🤖 Prompt for AI Agents