Skip to content

feat(omp): add Oh My Pi extension plugin - #1099

Merged
rohitg00 merged 13 commits into
rohitg00:mainfrom
JackieJK:feat/omp-plugin
Oct 25, 2026
Merged

rohitg00 merged 13 commits into
rohitg00:mainfrom
JackieJK:feat/omp-plugin

Conversation

@JackieJK

@JackieJK JackieJK commented Jul 22, 2026 •

Copy link
Copy Markdown
Contributor

Bundle Oh My Pi setup through agentmemory connect omp, with native recall/capture, 17 skills and optional full MCP tools. Add offline replay, privacy filtering and stable event IDs while preserving user configuration and complete model tool output.

Validated the packed install with OMP 18.12.6 and iii 0.25.0: native/MCP tools, status and skill commands, session switching and offline restart/replay. Full suite: 3,968 passed, 4 skipped.

@vercel

vercel Bot commented Jul 22, 2026

Copy link
Copy Markdown

@JackieJK is attempting to deploy a commit to the rohitg00's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
Walkthrough

Adds an Oh My Pi extension for AgentMemory. It provides memory tools, prompt recall, session and tool observation, file-context enrichment, lifecycle telemetry, shutdown processing, installation documentation, and bearer-auth protection.

Changes: Oh My Pi AgentMemory integration

Layer / File(s) Summary
Integration setup and transport security
integrations/omp/package.json, integrations/omp/security.ts, integrations/omp/README.md
Defines the extension package, documents installation and configuration, and adds secret resolution and configurable protection for plaintext bearer authentication.
Extension core and memory tools
integrations/omp/index.ts
Adds AgentMemory request helpers, session and project state, health reporting, and the memory_health, memory_search, and memory_save tools.
Prompt recall and session observation
integrations/omp/index.ts
Adds prompt-time memory recall, tool and conversation observations, file-context enrichment, and compaction context retrieval.
Shutdown and lifecycle telemetry
integrations/omp/index.ts
Adds bounded shutdown processing, optional consolidation and summarization, session-end reporting, and permission, compaction, and retry observations.

Priority: Normal

Estimated code review effort: 4 (Complex) | ~45 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant OhMyPi
  participant agentmemoryExtension
  participant AgentMemoryServer
  OhMyPi->>agentmemoryExtension: Submit prompt
  agentmemoryExtension->>AgentMemoryServer: Check health and search memories
  AgentMemoryServer-->>agentmemoryExtension: Health status and recalled memories
  agentmemoryExtension-->>OhMyPi: Add recalled memories to system prompt
  OhMyPi->>agentmemoryExtension: Send tool, permission, compaction, and retry events
  agentmemoryExtension->>AgentMemoryServer: Post observations
  OhMyPi->>agentmemoryExtension: End session
  agentmemoryExtension->>AgentMemoryServer: Drain posts and process session shutdown
Loading
Merge Risk: Moderate · up to 65a47

Recalled memories and file-derived context are injected into the model as system and developer instructions. Stored or file-derived text containing instructions could therefore be followed as trusted guidance. Delivering this content as clearly labeled reference data would reduce that exposure. Consider resolving or explicitly accepting this before merge.

Pre-merge checks: Passed 3 · Failed 2

Failed Failed checks: 2 warnings

Check name Status Explanation Resolution
Linked Issues check Warning Issue #1086 requires native plugin and MCP support. The PR adds a native omp extension in integrations/omp/index.ts, with lifecycle hooks, tools, and a command. The README explicitly states, “This e… Add the MCP support required by issue #1086, including its implementation and automated tests. Keep the native omp extension behavior covered by tests where applicable.
Docstring Coverage Warning Docstring coverage is 4.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 25 functions across 2 files. (2 skipped: 2… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 3 passed
Check name Status Explanation
Title check Passed The title "feat(omp): add Oh My Pi extension plugin" matches the main change. The PR adds an Oh My Pi (omp) extension in integrations/omp, with index.ts, security.ts, package.json, and a README. The e…
Out of Scope Changes check Passed The reviewed changes add only the omp extension package, its security helpers, documentation, and package metadata. The hooks, tools, command, HTTP integration, and security handling support the nativ…
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check

Explanation

The title "feat(omp): add Oh My Pi extension plugin" matches the main change. The PR adds an Oh My Pi (omp) extension in integrations/omp, with index.ts, security.ts, package.json, and a README. The extension hooks into the omp ExtensionAPI, registers memory tools and a status command, and connects to the AgentMemory server. The title is short, specific, and uses a conventional commit style. It does not mention the security guard or MCP support, but those are secondary details. The linked issue asks for MCP as well, and the PR description does not state that MCP is included. That gap concerns issue scope, not the title.

Full details: Out of Scope Changes check

Explanation

The reviewed changes add only the omp extension package, its security helpers, documentation, and package metadata. The hooks, tools, command, HTTP integration, and security handling support the native omp integration requested by issue #1086. No unrelated change is demonstrated.

Full details: Linked Issues check

Explanation

Issue #1086 requires native plugin and MCP support. The PR adds a native omp extension in integrations/omp/index.ts, with lifecycle hooks, tools, and a command. The README explicitly states, “This extension uses omp's extension API, not MCP,” and no MCP implementation is present in the reviewed changes. The MCP requirement remains unmet.

Resolution

Add the MCP support required by issue #1086, including its implementation and automated tests. Keep the native omp extension behavior covered by tests where applicable.

Full details: Docstring Coverage

Explanation

Docstring coverage is 4.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 25 functions across 2 files. (2 skipped: 2 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

✨ Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JackieJK JackieJK changed the title feat(omp): add Oh My Pi agentmemory extension plugin feat(omp): add full lifecycle hooks to omp integration Jul 22, 2026
@JackieJK JackieJK changed the title feat(omp): add full lifecycle hooks to omp integration feat(omp): add Oh My Pi extension plugin Jul 22, 2026
@JackieJK
JackieJK marked this pull request as ready for review August 4, 2026 08:23
coderabbitai[bot]

This comment was marked as resolved.

@JackieJK
JackieJK marked this pull request as draft August 4, 2026 09:22
- Replace local sha256/randomUUID with fingerprintId/generateId primitives
- Align AGENTMEMORY_INJECT_CONTEXT ('1') and AGENTMEMORY_CONSOLIDATION_ENABLED (default on, '0' disables) with README
- Separate currentProject (project payload) from currentCwd (cwd payload)
- Make session_before_compact async and await context fetch; clear cachedContext on consume
- Add omp manifest to package.json so omp plugin discovery loads the extension
- Fix README install instructions (omp plugin install + plugin doctor, not extensions/ copy)
@JackieJK
JackieJK marked this pull request as ready for review August 4, 2026 10:07
…gainst copy to ~/.omp/agent/extensions (double-load)
devin-ai-integration[bot]

This comment was marked as resolved.

rohitg00 and others added 2 commits October 23, 2026 17:56
- before_agent_start: event.systemPrompt is now string[]; append the recall
  block as an extra line and return nothing when there is nothing to inject,
  instead of flattening and overriding the host prompt every turn
- drop dead systemPromptOptions.cwd cast (removed upstream); use ctx.cwd
- context enrich injection: role 'system' is not a valid AgentMessage in
  omp 18.12 (unknown roles convert as assistant); use a developer message
- registerTool: hoist parameter schemas to consts so Static<> infers params,
  set loadMode essential so memory tools stay top-level
- sync security.ts with the deployed plugin: resolveSecret falls back to
  ~/.agentmemory/secret and ~/.agentmemory/.env on loopback URLs
- bump integration version to 0.9.30; document omp 18.12 requirement
devin-ai-integration[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

Signed-off-by: Rohit Ghumare <ghumare64@gmail.com>
Signed-off-by: Rohit Ghumare <ghumare64@gmail.com>
Signed-off-by: Rohit Ghumare <ghumare64@gmail.com>

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 3 new potential issues.

Devin Review

Comment thread integrations/omp/capture.ts Resolved
Comment thread src/cli/connect/omp.ts Resolved
Comment thread integrations/omp/index.ts Resolved
Signed-off-by: Rohit Ghumare <ghumare64@gmail.com>
@rohitg00
rohitg00 merged commit 2755916 into rohitg00:main Oct 25, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants