feat: Add pluggable bank sync connector architecture#655
Open
flaggdavid-source wants to merge 1 commit intorohitdash08:mainfrom
Open
feat: Add pluggable bank sync connector architecture#655flaggdavid-source wants to merge 1 commit intorohitdash08:mainfrom
flaggdavid-source wants to merge 1 commit intorohitdash08:mainfrom
Conversation
- Add BaseBankConnector abstract class with TokenInfo, Account, Transaction dataclasses - Add factory pattern with register_connector decorator and get_connector function - Add MockBankConnector for testing/development - Add bank_connectors API routes with OAuth flow and import support - Add 19 tests covering all components Implements: - Connector interface (BaseBankConnector) - Import & refresh support (OAuth flow + /import/transactions endpoint) - Mock connector included (MockBankConnector)
458b33a to
29e036d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements a pluggable architecture for bank integrations as requested in issue #75.
Changes Made
1. Base Connector Interface (
app/services/connectors/base.py)BaseConnectorabstract class withauthenticate(),import_transactions(),refresh_accounts()methodsTransactionandAccountdataclasses for data representationConnectorConfigfor configuration managementConnectorError,AuthenticationError,ImportError,RefreshError2. Mock Connector (
app/services/connectors/mock.py)MockConnectorimplementation for testing and development3. Connector Registry (
app/services/connectors/registry.py)ConnectorRegistryfactory pattern for dynamic loadingget_connector(),list_connectors(),create_connector()4. Unit Tests (
tests/test_connectors.py)Usage Example
All 29 tests pass.