Repository navigation
fix(test): ensure npm test discovers suite - #35
Merged
Merged
Conversation
rogerchappel
marked this pull request as ready for review
October 5, 2026 12:39
rogerchappel
enabled auto-merge (rebase)
October 5, 2026 12:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the npm test glob so it locates compiled files under
dist/test/. Add a discovery guard that fails if the configured test command succeeds without running tests.Commits:
67b10b9 fix(test): discover compiled test files— point npm test to compiled test output.7c89ff1 test: guard against empty test discovery— add an executable empty-discovery check.Files:
package.json,scripts/check-test-discovery.mjs.Verification
npm run test:discovery— passed; discovered 28 tests.npm run check— passed.npm run build— passed.git diff --check— passed.npm test— passed; 28 tests.Manual review: confirmed the release workflow is tag-triggered only; a branch push and draft PR cannot publish or deploy.
Risk Level
Rollback Plan
Revert the two commits.
Human Decision Needed