Port to Qt6 - #199
Open
diegoiast wants to merge 3 commits into
Open
Conversation
I ported only CMake. QMake is not modified. Code may (?) compile with Qt5, but I am not dealing with it. I run the code once. Code does seem to work, but I do know that "opening" a file is no longer working. Copy does seem to work (which means also move). Delete as well. qtfm-tray does load, but does nothing. I did not look into it any more. Code in Qt6 behaves better in Wayland and probably in HighDPI in Windows/OSX - so this is another good reason to upgrade (and Qt5 is EOL).
|
@rodlie @diegoiast If it is possible to do without breaking Qt4 build, it will be great. I.e. retain fallbacks where needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am only dealing with CMake, and PRO files are legacy as Qt5. Code runs, but I cannot open external files (clicking a TXT file does nothing for example). The tray , does nothing. Menus behave properly now as Qt5 has very bad Wayland support. I am testing against Qt from debian, 6.8.3 and 6.9.0 from upstream. Not compiling with MAGIC support.
On the left, Qt5 build before the changes. On the right, Qt from debian:
IMHO the code can be made to compiler on Qt5 (the normal CMake magic - just modify at the top,
Qt::Widgetsworks on Qt5 and Qt6). I don't see any reason to spend time on this.