Compatibility with rice version 4.x #178
Open
+25
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doudou
reviewed
Jan 22, 2026
| EXT_RICE base_types_ruby Eigen.cpp init.cpp) | ||
| endif(SISL_FOUND) | ||
|
|
||
| target_compile_features(base_types_ruby PUBLIC cxx_std_17) |
Member
There was a problem hiding this comment.
This is base-types ... I would avoid doing that blindly.
If the goal is to support rice > 4, could you do it conditionally.
Member
Author
There was a problem hiding this comment.
By "conditionally", do you mean checking the rice version, or adding a cmake flag?
I can try either. I think I had problems finding out the rice version (by cmake), but it has been a while (I had this change as local fix some time before I made this PR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if that is the correct way to handle compatibility with rice 4.x