Changes generating pkg-config .pc files #96
Draft
+22
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example the INTERFACE_LINK_LIBRARIES is allowed to contain generator expressions
Some packages had a ridiculous amount of cflags and ldflags in their pkgconfig .pc files.
Contributor
Author
|
This needs a bit more work, now we can potentially get multiple .pc files generated and cmake complains in that case. Edit: This was a package calling rock_prepare_pkgconfig twice, i thought it was something about the file being recreated for different configs for some reasone. |
Contributor
Author
|
This will make calling rock_prepare_pkgconfig twice for the same target an error, where before it just silently recreated the .pc file. @doudou i don't think that would be an issue except for packages misusing rock_library? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.