Fix OBB IoU for non-square canvases#2282
Open
RitwijParmar wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
oriented_box_iou_batchcanvas sizing so x coordinates determine width and y coordinates determine heightFixes #2278.
Why this matters
OBB evaluation currently rasterizes polygons onto a canvas with width/height swapped. For non-square extents this can clip the polygons away and return zero IoU, which then makes otherwise correct OBB detections look like complete failures across the metrics stack. This is especially painful for real-world CV datasets where rotated boxes are common for aerial imagery, floorplans, traffic scenes, and industrial inspection.
Tests
.venv/bin/python -m ruff check src/supervision/detection/utils/iou_and_nms.py tests/detection/utils/test_iou_and_nms.py tests/metrics/test_mean_average_precision.py tests/metrics/test_oriented_bounding_box_metrics.py.venv/bin/python -m pytest tests/detection/utils/test_iou_and_nms.py::test_oriented_box_iou_batch_is_invariant_to_non_square_scaling tests/metrics/test_oriented_bounding_box_metrics.py.venv/bin/python -m pytest tests/detection/utils/test_iou_and_nms.py tests/metrics/test_oriented_bounding_box_metrics.py tests/metrics/test_mean_average_precision.py tests/metrics/test_mean_average_recall.py tests/metrics/test_precision.py tests/metrics/test_recall.py tests/metrics/test_f1_score.py