Flexible annotation/image filename matches#417
Merged
iurisilvio merged 9 commits intomainfrom Nov 4, 2025
Merged
Conversation
| or image_path_to_annotation_files.get(image["name"], []) | ||
| or image_path_to_annotation_files.get(image["key"], []) | ||
| or annotationFiles # Fallback to all files for non-COCO formats | ||
| ) |
There was a problem hiding this comment.
Bug: Fallback Annotation Mapping Causes Inefficiency
The _map_annotations_to_images_1tomany function includes a fallback to annotationFiles that causes images to be checked against all annotation files if the index yields no specific matches. This can lead to inefficient processing and potentially incorrect annotation assignments, as images might be matched to unrelated files.
digaobarbosa
approved these changes
Oct 8, 2025
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix annotation imports with inconsistent image file names or with images in subfolders.
Type of change
How has this change been tested, please provide a testcase or example of how you tested the change?
Added a test to validate the scenario.
Note
Improves folder parsing to reliably match annotations to images (including COCO with subdirectory file_names), and adds tests for these cases.
roboflow/util/folderparser.py_build_image_to_annotationfile_indexsupportingcoco,createml,csv,multilabel_csv, andjsonl._filterIndividualAnnotationsto try multiple keys (rel path → basename → stem) and corrects annotation map lookup keys.tests/util/test_folderparser.pyfile_namematch root-level images.__version__to1.2.11.Written by Cursor Bugbot for commit 76ae33f. This will update automatically on new commits. Configure here.