Skip to content

Bugfix: no files downloaded when overwrite=False#24

Open
leeclemnet wants to merge 3 commits intomainfrom
fix/overwrite-false
Open

Bugfix: no files downloaded when overwrite=False#24
leeclemnet wants to merge 3 commits intomainfrom
fix/overwrite-false

Conversation

@leeclemnet
Copy link
Copy Markdown

What does this PR do?

Currently RF100VlDataset.download() creates the target directory before calling latest_version.download(). The roboflow SDK's Version.download() with overwrite=False checks whether the destination directory already exists — if it does, it assumes the dataset was already downloaded and skips the actual download. Since Version.download() already handles directory creation, we can just remove it from RF100VlDataset.download() to fix the issue

Type of Change

  • Bug fix (non-breaking change that fixes an issue)

Testing

  • I have tested this change locally
  • I have added/updated tests for this change

Test details:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code where necessary, particularly in hard-to-understand areas
  • My changes generate no new warnings or errors
  • I have updated the documentation accordingly (if applicable)

Additional Context

@leeclemnet leeclemnet marked this pull request as ready for review March 18, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant