Repository navigation
mgu-install: ENET on Windows without ssh -b; link-local checks; quoted-path hint - #342
Merged
Merged
Conversation
…d-path hint
- On Windows, ssh connects to the head unit found over ENET without -b:
the OpenSSH client that comes with Windows fails every connection made
with a bind address ("Invalid argument").
- Only a link-local host address (169.254.1.0 to 169.254.254.255, not the
computer's own) is tried as the head unit's. When its SSH does not
answer, the message names the ENET addresses tried and --host <address>.
- An unquoted --identity or --from path split at a space gets "the path
has a space: put it in quotes", with the whole path given back.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Over ENET, mgu-install finds the head unit and then runs
ssh -b <adapter address>. The OpenSSH client that comes with Windows fails every connection made with a bind address, whatever the target:ssh: connect to host <address> port 22: Invalid argument. This matches #77, which was solved by giving--host(no-b).-b. The link-local route picks the adapter. macOS and Linux still bind.62 17 2A 00, followed by address, subnet mask and gateway (4 bytes each), so the address read is already the head unit's. An address ending in.0is a valid head unit address and is used.--host <address>can be given.--identityor--frompath with a space is split by the shell, the error saysthe --identity path has a space: put it in quotes, --identity "<whole path>".AI: Claude Code, Claude Opus 5.5
Tested:
deploy/test/connect_test.js(all pass). New checks: no-bon Windows with a head unit atx.x.x.0; the link-local range limits; the full DID answer layout; a reported address that cannot be the head unit skipped; the computer's own address never tried; the tried addresses and--hostin both failure messages; the split-path hint for--identityand--from. Full deploy suite (deploy/test/run.sh). Not tested on Windows with a car over ENET, and not on a car at all; the Windows behaviour rests on the OpenSSH for Windows source and the report in #77.Human review: no
Screenshots: n/a
🤖 Generated with Claude Code