Skip to content

mgu-install: ENET on Windows without ssh -b; link-local checks; quoted-path hint - #342

Merged
robertnisipeanu merged 1 commit into
mainfrom
fix-enet-hu-discovery
Nov 19, 2026
Merged

robertnisipeanu merged 1 commit into
mainfrom
fix-enet-hu-discovery

Conversation

@robertnisipeanu

Copy link
Copy Markdown
Owner

Over ENET, mgu-install finds the head unit and then runs ssh -b <adapter address>. The OpenSSH client that comes with Windows fails every connection made with a bind address, whatever the target: ssh: connect to host <address> port 22: Invalid argument. This matches #77, which was solved by giving --host (no -b).

  • Windows: ssh connects to a head unit found over ENET without -b. The link-local route picks the adapter. macOS and Linux still bind.
  • Address checks: only a link-local host address (169.254.1.0–169.254.254.255, RFC 3927; any last byte) other than the computer's own is tried as the head unit's, for the address from DID 22 17 2A and the remembered one. The DID answer is 62 17 2A 00, followed by address, subnet mask and gateway (4 bytes each), so the address read is already the head unit's. An address ending in .0 is a valid head unit address and is used.
  • Messages: when no address answers SSH, or the head unit's SSH is closed, the error names the ENET addresses tried and says --host <address> can be given.
  • Unquoted paths: when an --identity or --from path with a space is split by the shell, the error says the --identity path has a space: put it in quotes, --identity "<whole path>".

AI: Claude Code, Claude Opus 5.5

Tested: deploy/test/connect_test.js (all pass). New checks: no -b on Windows with a head unit at x.x.x.0; the link-local range limits; the full DID answer layout; a reported address that cannot be the head unit skipped; the computer's own address never tried; the tried addresses and --host in both failure messages; the split-path hint for --identity and --from. Full deploy suite (deploy/test/run.sh). Not tested on Windows with a car over ENET, and not on a car at all; the Windows behaviour rests on the OpenSSH for Windows source and the report in #77.

Human review: no

Screenshots: n/a

🤖 Generated with Claude Code

…d-path hint

- On Windows, ssh connects to the head unit found over ENET without -b:
  the OpenSSH client that comes with Windows fails every connection made
  with a bind address ("Invalid argument").
- Only a link-local host address (169.254.1.0 to 169.254.254.255, not the
  computer's own) is tried as the head unit's. When its SSH does not
  answer, the message names the ENET addresses tried and --host <address>.
- An unquoted --identity or --from path split at a space gets "the path
  has a space: put it in quotes", with the whole path given back.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@robertnisipeanu
robertnisipeanu merged commit 1a64e01 into main Nov 19, 2026
12 checks passed
@robertnisipeanu
robertnisipeanu deleted the fix-enet-hu-discovery branch November 19, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant