Repository navigation
Updater: refresh the Store after outside changes; deploy: refuse removing a required component - #341
Merged
Merged
Conversation
…omponent The updater sends its state again when the installed tools and apps change outside its own actions, and after it refuses an install, update or removal. The deploy tool's uninstall refuses a component that an installed app or tool still depends on, and remove-all removes dependents first. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Store learns what is installed only from the state the updater sends, so a component installed or removed outside the updater (the deploy tool run on the command line) stayed on screen as before until the Store connected again. The deploy tool's
uninstallalso removed a tool that an installed app still required, which the updater itself refuses.mgu-updater
/var/opt/<id>/current/component.json) and apps (MainApp's registry and each app'spackage.json). When that set differs from the last read and the updater is not busy with its own change, it asks the deploy tool for its status again and sends the state to connected clients. The check only reads files and writes nothing.mgu-deploy
uninstall <id>refuses while an installed component still depends on it, and names those components. A component depends on a tool when it requires it (from itscomponent.jsonor the requirements the updater recorded at its install) or needs a capability only that tool provides. An app queued for removal at the next start does not count, and a reinstall (keepPackages) is not checked.remove-allorders tools by the same rule, so dependents go first.AI: Claude Code, Claude Opus 5.5
Tested:
native/mgu-updater/test/test_updater.js, Node 8.16.2): 646 passed. A new check confirms that a tool removed outside the updater, and a refused Remove, each push the state to a connected client.deploy/test/run.sh): all passed. The newtestUninstallRequiredconfirms that a tool required by an installed app is refused and is removed once the app is gone. The remove-all tests pass with the new order.mgu-deploy.sh uninstall mgu-inputgate --yeswas refused with "mgu-inputgate is required by live_data; uninstall it first" (exit 2), and the gate stayed installed.Human review: no
Screenshots: n/a
🤖 Generated with Claude Code