Repository navigation
Conversation
…s subscribed A target whose renderer never subscribes to its scene is recovered on the ladder, and every third recovery in a row the unit reconnected its RAMSES framework. The reconnect is for a participant session the renderer side no longer serves. But when another target's scene is subscribed on the same framework, the session is served: only the one target's renderer is absent. The reconnect then cannot help it, and it drops every other target's content. A healthy panel was removed and fetched again every ~90 s, and the removals lowered the upload cap. The reconnect now goes only while no other target's published scene has a renderer subscribed. Otherwise the skip is logged with the subscribed target and renderer. The recovery itself, the reconnect for stalled fetches and the case with no target subscribed are unchanged. service_test: a panel subscribed and shown next to a hud whose renderer never subscribes. Over 9 recoveries there is no reconnect and the panel is never lost. With the panel's renderer gone too, one reconnect is asked. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On an iDrive 7 head unit (0.6.9), an app had the
hudtarget switched on, but that unit's HUD renderer never subscribes to the hud's scene. The rendering check recovers the hud again and again, as it should:Every third recovery in a row, though, it reconnects the RAMSES framework:
That reconnect drops every content of the participant, including the
paneltarget, which was fine the whole time (rendered: renderer ...0001 subscribed for 1150 s):So the panel disappeared for about 2 s every ~92 s because of a target whose renderer is not there. The removals also lowered the upload cap (
lowered from 5500 KB/s: in 30 s, 2 x scene removed).The reconnect (0f21561) is for a participant session the renderer side no longer serves, e.g. one the display kept over a restart of this side. In that case no target of ours gets a subscription. When another target's scene is subscribed on the same framework, the session is served and a reconnect cannot help the one target. It only takes the other targets down.
Design
SlotManager::verify: at everykReconnectAfter-th recovery in a row, the reconnect goes only if no other target's published scene has a renderer subscribed. Otherwise one line is logged instead:target hud: no renderer subscription through 3 recoveries in a row; the RAMSES framework not reconnected: target panel's scene 0x10004f8 is subscribed by renderer <guid>kReconnectAfter-th recovery of either target reconnects as before, at most once perkReconnectGapMs.on_renderer_stuckcomment say so. README and PROTOCOL.md do not describe this reconnect, so they are unchanged.Tests
make test: 1678 checks pass (1674 on main).kReconnectAfter) there is no framework reconnect, each skip is logged, and the panel stays mapped, shown and rendered and is never lost. Then the panel's renderer goes too, and exactly one reconnect is asked. With main's slots.cpp, three of the four checks fail: the hud reconnects at its 3rd and 9th recovery, and the panel's mapping is dropped.kReconnectAfterrecoveries) passes unchanged.🤖 Generated with Claude Code