Skip to content

cluster-render hide_badge; waze-on-cluster: hiding BMW's guidance covers the car's badge too - #221

Closed
TheoneLT83 wants to merge 1 commit into
robertnisipeanu:mainfrom
TheoneLT83:pr/hide-badge
Closed

TheoneLT83 wants to merge 1 commit into
robertnisipeanu:mainfrom
TheoneLT83:pr/hide-badge

Conversation

@TheoneLT83

Copy link
Copy Markdown

cluster-render: hide_badge (layer option, PROTOCOL.md): a map layer with it keeps the guide hold up with no turn box mapped, so the KOMBI's badge in that slot (eDrive logo, M emblem) is covered while the map shows. With guide_slots = auto and no box seen yet, the hold takes the first of its slots the slot table reports available (0x105, else 0x103), where before it had no slot at all until BMW's turn panel showed (so with Waze and no BMW route the badge always showed).

waze-on-cluster: sets hide_badge together with guide_hold, so the app's existing switch for BMW's guidance covers the badge too. requires cluster-render next.

Tests: slots_test.cpp (held with no box, released after the flag clears; auto picking 0x105, or 0x103 with 0x105 disabled; no slot without the flag) and map_feed_test.cpp.

Screenshots: none taken from this branch; on the car the badge at the top of the map is covered by the empty hold while the switch is on.

AI: Claude Code, Claude Opus 5.5 (ported from TheoneLT83/Cluster-apps, cluster-render 0.6.8 and 0.6.10 there). Tested: on this branch: cluster-render make test (all pass) and waze-on-cluster make test-cpp (all pass). Not tested on a car from this branch. Human review: TheoneLT83 asked for this pull request; the code was not reviewed line by line by a person.

🤖 Generated with Claude Code

Merge Idrive7 assistant versions

… waze-on-cluster: hiding BMW's guidance covers the car's badge

A map layer with hide_badge keeps the guide hold up with no turn box mapped, so the KOMBI's badge (eDrive logo, M
emblem) in that slot is covered while the map shows; with guide_slots = auto and no box seen yet, the hold takes the
first of its slots the slot table reports available. waze-on-cluster sets it with guide_hold.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RaQUWvi4djHaPEqip7eCr8
@robertnisipeanu

Copy link
Copy Markdown
Owner

Thanks for this. Closing it, because it would be a regression: "Hide BMW's turn box" covering the slot while no turn box is shown is the behaviour #181 changed on purpose. With it, the car's badge (eDrive logo, M emblem) disappeared whenever the map showed, which was reported in robertnisipeanu/mgu-store#304. #181 holds the slot only while BMW's turn box is there, so the badge stays visible without a route.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants