Repository navigation
waze-on-cluster: Android Auto self-start waits for the cluster display; Android Auto always comes back - #215
Merged
Merged
Conversation
…y; stricter aapd checks; Android Auto always restarted requestStream's opening test reads the cluster display's ready flag, so the self-started request no longer reaches SetVideoFocus before the phone has set its cluster display up (Cinemo refuses it, aapd aborts on the uncaught exception). The locator ties the self-start to the session start and end, the gate's kept flag to the code it turns on, and reads the earlier guard as outdated. A crash of the patched aapd restores the original at once, aapd is started again after every end with a growing delay, and the patch stays off until its Patch button or a newer patch revision applies it. Save logs adds aapd's journal, the crash handler's record of aapd's crashes and the patch's site report. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… a local conf Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1031527554
added a commit
to 1031527554/idrive-apps-ls
that referenced
this pull request
Nov 19, 2026
…6.12); drop Map layout Upstream removed the plumbing this fork's Map layout stood on: PR robertnisipeanu#214 takes away the `target` setting, `map_rect`'s part in choosing a target and the control socket's `start` command, so the cluster map always goes on its own map slot (or into a hosting app's scene). The fork's Full width and Full screen cannot exist without it, and the owner uses Central — what upstream does now — so the feature goes rather than diverge. `native/waze-on-cluster` and `apps/robertn_waze_cluster` are upstream's trees again, which removes the app's Map layout row, its locales words, the tool's `map_layout.h`, the `layout` config key, control command and status field, `patchd`'s `saveLayout`, and both sides' tests. `MAINTAINING.md` records what the fork used to carry and why neither feature is here. Also in this range: Android Auto no longer drops out until a head-unit restart (the self-start edit waited for the cluster display, robertnisipeanu#215), no local conf is read any more, an accepted-but-never-completed fetch is recovered, the upload ceiling is remembered across drives, the arrival-time card is asked for in the ShowUI URL, and Save logs scrubs secrets, USB serials and the VIN.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android Auto could drop out with the Android Auto patch installed and come back only after a head-unit restart (mgu-store#326). This fixes the cause in the patch, makes the locator check more of each build, keeps Android Auto running whatever happens to aapd, and adds what an aapd failure needs to Save logs.
The patch. The self-start edit makes
onNewNavigationStatus()callrequestStream(), which calls the cluster display'sSetVideoFocus(). Cinemo refuses that call until the phone has set its cluster display up ("Unable to SetVideoFocus() without active player or correct configuration!");throwOnCinemoErrorthrows and nothing catches it, so aapd aborts (SIGABRT). That happens on a navigation status before the display is ready, after a session ends, or with a phone that offers no cluster display. The guard edit now replaces requestStream's opening test with cluster display ready ([this+0x41], set byonAlternateVideoReady(), cleared byonEndSession()) and not streaming, the same precondition the car's own request has. It is 16 bytes at0x1d3f53in aapd 22.39.3; the guard written by earlier releases readsoutdatedand an install replaces it. The patch record keeps the patch revision (rev, 2).Checks, no build list. Besides the existing ones, the locator requires: requestStream's test reads its own
this;onAlternateVideoReady()sets exactly one byte flag and subscribes to the stream commands;onEndSession()clears that flag, the stream status and the focus mode the test uses; the patched test reads that flag;initAlternateDisplays()and every branch intoonNewNavigationStatus()test the gate's kept result. A build of another version patches when its code has this shape; one that does not is refused with the reason and left as it is. Each check alone refuses a changed build inaapd_locate_test.js.aapd_patch.js probe(woc-patch.sh aa-probe) prints every site's offset, bytes and both forms.Recovery. A crash of the patched aapd restores the original at once (watcher or boot step), before the start, and records
why(crashorboot) and the removed patch'srev. aapd is started again after every end the watcher sees (a crash, a SIGKILL patchd did not send, a clean exit), 2, 5, 15 and 30 s after the first ends in a row, then every 60 s, with no limit; a run healthy for 60 s makes the next start quick again. A crash of the run that was up when an install wrote a new patch (it runs the replaced file) is not counted. The patch stays off until its Patch button applies it or an install brings a newer revision; patchd reportsrecoveredWhywithrecovered. Nothing here restarts the head unit. CarPlay's recovery is unchanged.Save logs adds this boot's journal of aapd and the Android Auto boot step, aapd and the boot step in the kept journal,
aapd-probe.txt, andaapd-crashes.txt: of the crash handler's records of aapd's newest 3 crashes only the signal, kernel stack, executable mappings, crash ids and summary (instruction and return addresses), never the environment, open files, memory or the core dump.The app's Status text for a crash restore is #216.
AI: Claude Code, Claude Opus 5.5 (investigation, implementation, review).
Tested:
make test-nodesuites with aapd 22.39.3, its aapd.conf, carplay 22.28.3 and aapd 23.16.5 (iD8, still refused): all pass.rollback_conf_test.jschecks only the releases that read a local conf (their shipped conf setslocal_conf; 0.10.10 does not), so it no longer fails on 0.10.10 as it does onmain.aapd_locate_test.js: 87 changed builds, 82 refused, 5 located correctly, none wrongly; every check proven.requestStream()call before the cluster display is set up ends interminate called after throwing ... CinemoExceptionandstatus=6/ABRT; with the new guard the same call logsIgnoring event. Already streaming...and aapd stays up;aapd-crashes.txtandaapd-probe.txtas above.Human review: none before opening.
Screenshots: n/a (nothing on screen changes in this pull request).
🤖 Generated with Claude Code