Skip to content

waze-on-cluster: no local conf; the cluster map always on its map slot - #214

Merged
robertnisipeanu merged 2 commits into
mainfrom
no-local-conf
Nov 18, 2026
Merged

robertnisipeanu merged 2 commits into
mainfrom
no-local-conf

Conversation

@robertnisipeanu

Copy link
Copy Markdown
Owner

waze-on-cluster runs from its shipped waze-on-cluster.conf (written anew by every install), the command line, the app's saved choices (map.state.conf, the turn-box setting) and the opt-in features.conf. No other tool can change how the map shows through a settings file of its own.

  • waze-on-cluster.local.conf is not read. A car that has one keeps it, so a downgrade finds what it had; the service logs one line naming it at each start. patchd still moves the opt-in and map keys out of it, so every earlier release starts with it.
  • features.conf stays, limited to hosted_vpp_scale and always_packed, each 0 or 1. Neither moves the map off its slot, and an app that hosts the map turns them on there.
  • The target setting, the control socket's start command and waze-on-cluster run are removed (nothing in the app uses them): on the cluster the map goes on its map slot, or into a hosting app's scene.
  • local_conf.{h,cpp} becomes opt_in.{h,cpp}, holding only the opt-in loader.
  • README and conf comments describe these settings.
  • rollback_conf_test.js also takes a car whose local conf has the owner's settings, the app's map settings and an opt-in key, and a car without one, through update, head-unit start, downgrade, Remove, uninstall and reinstall: every release from 0.5.0 to 0.10.9 starts with the files left, and no settings file is made where there was none.

AI: Claude Code, Claude Opus 5.5

Tested: make target (Docker build and import check), make test-x86 (the C++ host tests in Docker), make test-node (patchd, rollback and the other Node tests, rollback_conf_test.js included) all pass. Not run on a car or a test unit.

Human review: no

Screenshots: n/a

🤖 Generated with Claude Code

robertnisipeanu and others added 2 commits November 18, 2026 09:54
The service runs from its shipped waze-on-cluster.conf, the app's saved
choices and the opt-in features.conf. waze-on-cluster.local.conf is not
read: it stays on the unit for a downgrade and the log names it at each
start; patchd still moves the opt-in and map keys out of it. The target
setting, the control socket's start command and `run` are gone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…complete

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@robertnisipeanu
robertnisipeanu merged commit 4943952 into main Nov 18, 2026
9 checks passed
1031527554 added a commit to 1031527554/idrive-apps-ls that referenced this pull request Nov 19, 2026
…6.12); drop Map layout

Upstream removed the plumbing this fork's Map layout stood on: PR robertnisipeanu#214 takes
away the `target` setting, `map_rect`'s part in choosing a target and the
control socket's `start` command, so the cluster map always goes on its own
map slot (or into a hosting app's scene). The fork's Full width and Full
screen cannot exist without it, and the owner uses Central — what upstream
does now — so the feature goes rather than diverge.

`native/waze-on-cluster` and `apps/robertn_waze_cluster` are upstream's trees
again, which removes the app's Map layout row, its locales words, the tool's
`map_layout.h`, the `layout` config key, control command and status field,
`patchd`'s `saveLayout`, and both sides' tests. `MAINTAINING.md` records what
the fork used to carry and why neither feature is here.

Also in this range: Android Auto no longer drops out until a head-unit
restart (the self-start edit waited for the cluster display, robertnisipeanu#215), no local
conf is read any more, an accepted-but-never-completed fetch is recovered,
the upload ceiling is remembered across drives, the arrival-time card is
asked for in the ShowUI URL, and Save logs scrubs secrets, USB serials and
the VIN.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant