Repository navigation
Release 2.18.2 - #68
Merged
Merged
Conversation
Fixes a real, reproduced defect: Complete Installer step 18/18 ("KI-Stack
Desktop Control") failed with "Desktop-Control-Validierung fehlgeschlagen."
even though the same Install/Validate payload succeeded when run standalone.
Runs Desktop Control Install/Upgrade/Repair and the immediately following
Validate in a fresh pwsh process from Complete Installer, isolated from the
shared orchestrator process. Adds an optional, transaction-scoped
BackupRoot to Install-KIDesktopControl/Invoke-KIStackDesktopControl.ps1, and
makes Assert-KICompletePathAwareTransaction skip the BackupPath check only
for a Failed step whose rollbackStatus is already Completed.
Also fixes a real, reproduced Open WebUI startup defect found while
verifying the above: open-webui==0.11.3's own `serve` entrypoint
(open_webui/__init__.py) falls back to `Path.cwd() / '.webui_secret_key'`
whenever WEBUI_SECRET_KEY is not already set as an environment variable.
None of the KI-Stack starter chain ever changed directory, so starting the
stack from a shell whose current directory is C:\Windows\System32 (e.g. an
elevated shell opened the usual Windows way) made Open WebUI try, and
without admin rights fail, to write its persistent secret key there.
Open WebUI's separate WEBUI_SECRET_KEY_FILE env var is only honored by its
start.sh/start_windows.bat launchers, neither of which this starter uses,
so the fix instead has the generated Start-KIStack-OpenWebUI.cmd read
WEBUI_SECRET_KEY from a persistent, TargetRoot-scoped file
(<TargetRoot>\state\openwebui\.webui_secret_key, generated once,
cryptographically random, reused on every later start) and sets an
explicit, stable working directory, regardless of the caller's own CWD. A
legitimate pre-existing key at <TargetRoot>\.webui_secret_key (the path the
Desktop shortcut's WorkingDirectory=$TargetRoot convention would have
produced) is migrated and reused rather than replaced.
A follow-up real-target test then found that this second fix never actually
reached an existing installation: Complete Installer's compliance check for
the 'applications' component compares its Contracts/COMPONENTS.json pin
against the release string recorded in an existing target's own
modules/applications/installation.json, and the module's generated-content
change shipped without bumping that version -- so any already-installed
target stayed permanently reported compliant/Skip at the old version and
never received the regenerated Start-KIStack-OpenWebUI.cmd. Applications
advances from 1.4.11 to 1.4.12 (module.json, the release marker
Install-KIModuleApplications writes, the Contracts/COMPONENTS.json pin, the
embedded preflight/version-lock reference copies, and the README/Technical
Documentation tables), which makes Complete Installer correctly plan
Upgrade/Repair (never Skip) for an existing 1.4.11 target and re-run
Install-KIModuleApplications for real -- verified with a hermetic,
network-free fixture (a real venv with a planted open-webui==0.11.3
dist-info) proving the regenerated starter, the bumped marker, and
untouched pre-existing Applications/OpenWebUI data, plus a Complete
Installer planning-level proof of Skip -> Upgrade -> Skip using real
installation.json/components.json fixtures.
Complete Installer advances from 2.18.0 to 2.18.1. Desktop Control stays
0.1.0; WinApp stays 0.6.1; Cutover Runtime stays 1.6.14.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 2.18.2: runtime stability, central lifecycle wiring, Open Terminal lifecycle fixes, OpenWebUI secret-key persistence, WSL/SearXNG keeper stabilization, delivery/reconcile version updates.