Skip to content

studio: config-drift dashboard (live vs declared, one-click re-apply) #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robercano-ghbot merged 5 commits into from
Aug 8, 2026
Merged

studio: config-drift dashboard (live vs declared, one-click re-apply) #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
253ef3a
feat(config,deploy-server,studio): config-drift dashboard - drift det…
robercano Aug 6, 2026
6213e2f
fix(config,deploy-server,studio): address review findings on config-d…
robercano Aug 6, 2026
0db737d
fix(studio,config): address TESTS lens findings on config-drift re-ap…
robercano Aug 6, 2026
c92ec66
fix(deploy-server,studio): make config-drift check network-aware (iss…
robercano Aug 6, 2026
700a7cf
fix(deploy-server): close review gaps on the H1 network-aware fix (is…
robercano Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
224 changes: 200 additions & 24 deletions apps/deploy-server/src/server.ts
View file
Open in desktop

Large diffs are not rendered by default.

306 changes: 306 additions & 0 deletions apps/deploy-server/test/apply-config.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,6 +689,312 @@ describe("POST /api/apply-config — secret leak prevention", () => {
});
});

// ---------------------------------------------------------------------------
// forceStepIds query param (issue #153 — config-drift one-click re-apply)
// ---------------------------------------------------------------------------

describe("POST /api/apply-config — forceStepIds", () => {
it("parses and forwards forceStepIds to applyConfig", async () => {
process.env["DEPLOYER_PRIVATE_KEY"] =
"0xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";

const configMod = vi.mocked(await import("@redeploy/config"));
configMod.applyConfig.mockResolvedValue({
success: true,
executedStepIds: ["set-fee"],
skippedStepIds: ["grant-minter"],
completedStepIds: ["set-fee", "grant-minter"],
});

await doRequest(
port,
"POST",
"/api/apply-config?forceStepIds=set-fee,grant-minter",
JSON.stringify(VALID_CONFIG_SPEC),
);

expect(configMod.applyConfig).toHaveBeenCalledWith(
expect.objectContaining({ forceStepIds: ["set-fee", "grant-minter"] }),
);
});

it("composes correctly with ?network= (both params present)", async () => {
process.env["DEPLOYER_PRIVATE_KEY"] =
"0xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";

const configMod = vi.mocked(await import("@redeploy/config"));
configMod.applyConfig.mockResolvedValue({
success: true,
executedStepIds: ["set-fee"],
skippedStepIds: [],
completedStepIds: ["set-fee"],
});

const res = await doRequest(
port,
"POST",
"/api/apply-config?network=default&forceStepIds=set-fee",
JSON.stringify(VALID_CONFIG_SPEC),
);

expect(res.statusCode).toBe(200);
expect(configMod.applyConfig).toHaveBeenCalledWith(
expect.objectContaining({ forceStepIds: ["set-fee"] }),
);
});

it("absent forceStepIds param → forwarded as undefined", async () => {
process.env["DEPLOYER_PRIVATE_KEY"] =
"0xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";

const configMod = vi.mocked(await import("@redeploy/config"));
configMod.applyConfig.mockResolvedValue({
success: true,
executedStepIds: [],
skippedStepIds: [],
completedStepIds: [],
});

await doRequest(port, "POST", "/api/apply-config", JSON.stringify(VALID_CONFIG_SPEC));

expect(configMod.applyConfig).toHaveBeenCalledWith(
expect.objectContaining({ forceStepIds: undefined }),
);
});

it("empty string forceStepIds param → treated as no ids (undefined)", async () => {
process.env["DEPLOYER_PRIVATE_KEY"] =
"0xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";

const configMod = vi.mocked(await import("@redeploy/config"));
configMod.applyConfig.mockResolvedValue({
success: true,
executedStepIds: [],
skippedStepIds: [],
completedStepIds: [],
});

const res = await doRequest(
port,
"POST",
"/api/apply-config?forceStepIds=",
JSON.stringify(VALID_CONFIG_SPEC),
);

expect(res.statusCode).toBe(200);
expect(configMod.applyConfig).toHaveBeenCalledWith(
expect.objectContaining({ forceStepIds: undefined }),
);
});

it("a value made only of commas/whitespace → treated as no ids (undefined)", async () => {
process.env["DEPLOYER_PRIVATE_KEY"] =
"0xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";

const configMod = vi.mocked(await import("@redeploy/config"));
configMod.applyConfig.mockResolvedValue({
success: true,
executedStepIds: [],
skippedStepIds: [],
completedStepIds: [],
});

await doRequest(
port,
"POST",
"/api/apply-config?forceStepIds=%20,,%20,",
JSON.stringify(VALID_CONFIG_SPEC),
);

expect(configMod.applyConfig).toHaveBeenCalledWith(
expect.objectContaining({ forceStepIds: undefined }),
);
});

it("dedupes repeated ids (and trims whitespace) before forwarding", async () => {
process.env["DEPLOYER_PRIVATE_KEY"] =
"0xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";

const configMod = vi.mocked(await import("@redeploy/config"));
configMod.applyConfig.mockResolvedValue({
success: true,
executedStepIds: [],
skippedStepIds: [],
completedStepIds: [],
});

await doRequest(
port,
"POST",
"/api/apply-config?forceStepIds=set-fee,%20set-fee%20,grant-minter,set-fee",
JSON.stringify(VALID_CONFIG_SPEC),
);

expect(configMod.applyConfig).toHaveBeenCalledWith(
expect.objectContaining({ forceStepIds: ["set-fee", "grant-minter"] }),
);
});

it("over-cap id count → 400 Bad Request (non-SSE), applyConfig never called", async () => {
process.env["DEPLOYER_PRIVATE_KEY"] =
"0xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";

const configMod = vi.mocked(await import("@redeploy/config"));
const tooMany = Array.from({ length: 501 }, (_, i) => `s${i}`).join(",");

const res = await doRequest(
port,
"POST",
`/api/apply-config?forceStepIds=${tooMany}`,
JSON.stringify(VALID_CONFIG_SPEC),
);

expect(res.statusCode).toBe(400);
expect(res.headers["content-type"]).toBe("application/json");
const body = JSON.parse(res.body) as Record<string, unknown>;
expect(typeof body["error"]).toBe("string");
expect(configMod.applyConfig).not.toHaveBeenCalled();
});

it("an id exceeding the max length → 400 Bad Request (non-SSE), never echoes the value", async () => {
process.env["DEPLOYER_PRIVATE_KEY"] =
"0xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";

const configMod = vi.mocked(await import("@redeploy/config"));
const tooLongId = "a".repeat(257);

const res = await doRequest(
port,
"POST",
`/api/apply-config?forceStepIds=${tooLongId}`,
JSON.stringify(VALID_CONFIG_SPEC),
);

expect(res.statusCode).toBe(400);
const body = JSON.parse(res.body) as Record<string, unknown>;
expect(typeof body["error"]).toBe("string");
expect(res.body).not.toContain(tooLongId);
expect(configMod.applyConfig).not.toHaveBeenCalled();
});

it("a 400 from an invalid forceStepIds value happens BEFORE the SSE stream opens (no event-stream header)", async () => {
process.env["DEPLOYER_PRIVATE_KEY"] =
"0xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";
const tooLongId = "b".repeat(300);

const res = await doRequest(
port,
"POST",
`/api/apply-config?forceStepIds=${tooLongId}`,
JSON.stringify(VALID_CONFIG_SPEC),
);

expect(res.statusCode).toBe(400);
expect(res.headers["content-type"]).not.toMatch(/text\/event-stream/);
});

it("max-length id (exactly 256 chars) is accepted", async () => {
process.env["DEPLOYER_PRIVATE_KEY"] =
"0xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";

const configMod = vi.mocked(await import("@redeploy/config"));
configMod.applyConfig.mockResolvedValue({
success: true,
executedStepIds: [],
skippedStepIds: [],
completedStepIds: [],
});
const exactId = "c".repeat(256);

const res = await doRequest(
port,
"POST",
`/api/apply-config?forceStepIds=${exactId}`,
JSON.stringify(VALID_CONFIG_SPEC),
);

expect(res.statusCode).toBe(200);
expect(configMod.applyConfig).toHaveBeenCalledWith(
expect.objectContaining({ forceStepIds: [exactId] }),
);
});

it("repeated ?forceStepIds= params MERGE (not just the first one) — issue #153 review finding B5", async () => {
process.env["DEPLOYER_PRIVATE_KEY"] =
"0xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";

const configMod = vi.mocked(await import("@redeploy/config"));
configMod.applyConfig.mockResolvedValue({
success: true,
executedStepIds: [],
skippedStepIds: [],
completedStepIds: [],
});

await doRequest(
port,
"POST",
"/api/apply-config?forceStepIds=set-fee&forceStepIds=grant-minter",
JSON.stringify(VALID_CONFIG_SPEC),
);

expect(configMod.applyConfig).toHaveBeenCalledWith(
expect.objectContaining({ forceStepIds: ["set-fee", "grant-minter"] }),
);
});

it("a repeated param value can itself be comma-separated — both forms combine", async () => {
process.env["DEPLOYER_PRIVATE_KEY"] =
"0xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";

const configMod = vi.mocked(await import("@redeploy/config"));
configMod.applyConfig.mockResolvedValue({
success: true,
executedStepIds: [],
skippedStepIds: [],
completedStepIds: [],
});

await doRequest(
port,
"POST",
"/api/apply-config?forceStepIds=set-fee,grant-minter&forceStepIds=wire-token-into-vault",
JSON.stringify(VALID_CONFIG_SPEC),
);

expect(configMod.applyConfig).toHaveBeenCalledWith(
expect.objectContaining({
forceStepIds: ["set-fee", "grant-minter", "wire-token-into-vault"],
}),
);
});

it("max-count ids (exactly 500) is accepted", async () => {
process.env["DEPLOYER_PRIVATE_KEY"] =
"0xaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa";

const configMod = vi.mocked(await import("@redeploy/config"));
configMod.applyConfig.mockResolvedValue({
success: true,
executedStepIds: [],
skippedStepIds: [],
completedStepIds: [],
});
const exactly500 = Array.from({ length: 500 }, (_, i) => `s${i}`).join(",");

const res = await doRequest(
port,
"POST",
`/api/apply-config?forceStepIds=${exactly500}`,
JSON.stringify(VALID_CONFIG_SPEC),
);

expect(res.statusCode).toBe(200);
const callArgs = configMod.applyConfig.mock.calls[0]![0];
expect(callArgs.forceStepIds).toHaveLength(500);
});
});

// ---------------------------------------------------------------------------
// Regression — existing routes unaffected
// ---------------------------------------------------------------------------
Expand Down
Loading
Loading