Chaning config map to a configmap yaml file. #6
Open
rjhowe wants to merge 21 commits intorobbmanes:mainfrom
Open
Chaning config map to a configmap yaml file. #6rjhowe wants to merge 21 commits intorobbmanes:mainfrom
rjhowe wants to merge 21 commits intorobbmanes:mainfrom
Conversation
Author
|
No big deal if you think its better the other way :-) |
Owner
|
Sorry I totally missed this. I think it probably best if we add both options. I'll do both shortly. |
Owner
|
This is a big change, but appears to work fine in my test clusters. I have no CI/CD setup for this repo yet. Can you confirm this has worked in live environments @rjhowe ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So instead of running:
We can run the following with out needing to pull repo or use curl: