Skip to content

Add Simplified Chinese language files - #128

Merged
rmorgan001 merged 2 commits into
rmorgan001:masterfrom
songshugong:codex/add-zh-cn-language
Jun 2, 2026
Merged

Add Simplified Chinese language files#128
rmorgan001 merged 2 commits into
rmorgan001:masterfrom
songshugong:codex/add-zh-cn-language

Conversation

@songshugong

Copy link
Copy Markdown
Contributor

Summary

Adds Simplified Chinese (zh-CN) language support for GSS.

Changes

  • Adds zh-CN language resource files for GS Server, GS ChartViewer, and GS Utilities.
  • Registers zh-CN in the supported language list.
  • Includes the zh-CN files in the shared project output.
  • Adds /zh and /chinese command-line language switches for GS Server.

Validation

  • Ran xmllint --noout on all three new XAML files and GS.Shared.csproj.
  • Verified all zh-CN resource keys match the corresponding en-US resource keys:
    • GSServer: 728/728 keys
    • GSChart: 22/22 keys
    • GSUtil: 42/42 keys
  • Ran git diff --check.

Full solution build was attempted with dotnet build GSSolution.sln --no-restore, but this macOS environment does not have the Windows/.NET Framework 4.8.1 targeting pack or Visual Studio C++ targets required by the project.

@Principia4834

Principia4834 commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Initial checks
Built on dev machine with new language files - Ok
Built installer - Ok
Launch and visually check all screens, tabs and dialog boxes - Ok
GSServer runs with zh-CN language file
Observations:
Missing - provided by Google translate
<system:String x:Key="goGoTo">前往</system:String> and other occurrences of GoTo
<system:String x:Key="vceSopUnknown">码头未知</system:String>
<system:String x:Key="vceSopEast">东码头</system:String>
<system:String x:Key="vceSopWest">西码头</system:String>
<system:String x:Key="skyGoToDecPulse">前往 Dec 脉冲</system:String>
Consider Simulator => 模拟器 and SkyWatcher => 天空观察者
Consider RA => 赤经 and Dec => 赤纬 - many occurrences

Installer script requires zh-CN translations

@songshugong

Copy link
Copy Markdown
Contributor Author

Thanks for taking a look and for building/testing it.

I’ve pushed an update for the issues you pointed out. GoTo is now kept as “GoTo”, since it seems to work better as the command name here. The incorrect Side of Pier translations have been cleaned up, RA/Dec is now more consistently translated as 赤经/赤纬, and the installer script now has Simplified Chinese language support.

I also left SkyWatcher untranslated, since that looks like the product/brand name.

@songshugong
songshugong marked this pull request as ready for review June 2, 2026 16:43
@rmorgan001
rmorgan001 merged commit 57e0a30 into rmorgan001:master Jun 2, 2026
2 checks passed
@rmorgan001

Copy link
Copy Markdown
Owner

Thank you songshugong for the work you've done. I'll release a new beta soon.

Thanks Andy for the review, I probably would have missed most of what you found!

--Rob

@songshugong
songshugong deleted the codex/add-zh-cn-language branch June 15, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants