Skip to content

test(fixtures): frozen spike feature fixtures and range checks (LIM-41) - #25

Merged
rmems merged 2 commits into
mainfrom
compat/spike-fixtures-ranges
Jul 23, 2026
Merged

test(fixtures): frozen spike feature fixtures and range checks (LIM-41)#25
rmems merged 2 commits into
mainfrom
compat/spike-fixtures-ranges

Conversation

@rmems

@rmems rmems commented Jul 22, 2026

Copy link
Copy Markdown
Owner

Summary

Adds frozen spike-stream fixtures and CI assertions for deterministic outputs + documented ranges after the kinetic-signals boundary split.

  • New test/fixtures/spike_vectors.json (3 cases: burst, sparse, single-spike)
  • test/runtests.jl loads fixtures and asserts goldens + range invariants
  • JSON.jl as test-only dependency
  • README/AGENTS fixture pointers + half-open window note
  • CHANGELOG Unreleased entry

Linear / GitHub

Test plan

  • Pkg.test() — 212/212 pass
  • Spec + code quality subagent reviews passed
  • JSON not in runtime [deps]

Open in Devin Review

@linear-code

linear-code Bot commented Jul 22, 2026

Copy link
Copy Markdown

LIM-41

amazon-q-developer[bot]

This comment was marked as resolved.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 58 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: b00b8f80-964a-4c16-8ec9-217dc8771df3

📥 Commits

Reviewing files that changed from the base of the PR and between 37ce0bc and 18fb21b.

📒 Files selected for processing (6)
  • AGENTS.md
  • CHANGELOG.md
  • Project.toml
  • README.md
  • test/fixtures/spike_vectors.json
  • test/runtests.jl
✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch compat/spike-fixtures-ranges

Comment @coderabbitai help to get the list of available commands.

@codacy-production

codacy-production Bot commented Jul 22, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

devin-ai-integration[bot]

This comment was marked as resolved.

@rmems
rmems force-pushed the compat/spike-fixtures-ranges branch 2 times, most recently from 8169f05 to d846ce1 Compare July 22, 2026 09:40
@kilo-code-bot

kilo-code-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (6 files)
  • AGENTS.md
  • CHANGELOG.md
  • Project.toml
  • README.md
  • test/fixtures/spike_vectors.json
  • test/runtests.jl
Previous Review Summary (commit d846ce1)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit d846ce1)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (6 files)
  • AGENTS.md
  • CHANGELOG.md
  • Project.toml
  • README.md
  • test/fixtures/spike_vectors.json
  • test/runtests.jl

Reviewed by gemini-3.6-flash · Input: 77.8K · Output: 4.4K · Cached: 114.2K

Review guidance: REVIEW.md from base branch main

@codecov

codecov Bot commented Jul 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Add test/fixtures/spike_vectors.json with golden vectors, load/assert in
runtests.jl, JSON as test-only dep. Retargeted onto main after #24 merge.
Fixes Codacy CHANGELOG blank-line density and documents burst defaults.
@rmems
rmems force-pushed the compat/spike-fixtures-ranges branch from d846ce1 to f59afb3 Compare July 22, 2026 19:58
@rmems
rmems changed the base branch from docs/kinetic-signals-boundary to main July 22, 2026 19:58
@rmems
rmems merged commit d2229e2 into main Jul 23, 2026
9 checks passed
@gitar-bot

gitar-bot Bot commented Jul 23, 2026

Copy link
Copy Markdown

Important

You are using the Gitar free plan. Upgrade to unlock code review, CI analysis, auto-apply, custom automations, and more.

Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

compat: spike feature fixtures + documented output ranges (LIM-41)

1 participant