-
Notifications
You must be signed in to change notification settings - Fork 0
feat: experimental step plasticity + GPU step options #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f3fad69
chore: gitignore explore notes and playground results
rmems c2e30a0
deps: bump CUDA.jl to 6.x and use free_memory
rmems 7ba0a82
feat: add plasticity=:none to freeze readout Hebbian
rmems be44664
feat: experimental step plasticity, G1 kwargs, pair STDP
rmems 0adcd17
docs: document experimental step plasticity defaults
rmems 3d68752
fix: address PR review — plasticity validation, sync diags, tests
rmems 3a75df8
fix: skip Sentry capture for API contract errors
rmems 0179dc9
docs: require liquidcortex Sentry DSN (not rust project)
rmems 1ca03f0
fix: address remaining PR review + GPU Sentry tags; CI on 1.12 only
rmems 22ffbd6
ci: self-hosted GPU workflow on Julia 1.12
rmems 5b9df1c
ci: fix GPU workflow CUDA check to use project env
rmems 359a0f2
fix: GPU CI OOM flake, fork isolation, review hardening
rmems 42d2d4d
fix: stop GPU CI OOM by hard-reset between ensembles
rmems File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| name: GPU CI (self-hosted) | ||
|
|
||
| # Runs Julia package tests on the local RTX-class runner (labels: self-hosted, Linux, X64, gpu). | ||
| # CPU smoke stays on ubuntu-latest in ci.yml; this job exercises CUDA kernels. | ||
| # | ||
| # Security: never run untrusted fork PR code on the persistent self-hosted host | ||
| # (GitHub recommendation). Same-repo PRs, pushes, and manual dispatch only. | ||
| on: | ||
| pull_request: | ||
| branches: | ||
| - '**' | ||
|
rmems marked this conversation as resolved.
|
||
| push: | ||
| branches: | ||
| - main | ||
| - 'release/*' | ||
| workflow_dispatch: | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
|
|
||
| # Serialize per-ref so an unrelated PR does not cancel main/release GPU jobs. | ||
| # The single self-hosted runner still runs at most one job at a time. | ||
| concurrency: | ||
| group: liquidcortex-gpu-${{ github.repository }}-${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| gpu-test: | ||
| name: Julia 1.12 — GPU tests (self-hosted) | ||
| # Fork PRs: skip (do not checkout untrusted code onto the GPU host). | ||
| if: > | ||
| github.event_name != 'pull_request' || | ||
| github.event.pull_request.head.repo.full_name == github.repository | ||
| runs-on: [self-hosted, Linux, X64, gpu] | ||
|
rmems marked this conversation as resolved.
|
||
| timeout-minutes: 60 | ||
|
|
||
| env: | ||
| # Optional: report step! failures to liquidcortex project during CI | ||
| SENTRY_DSN: ${{ secrets.SENTRY_DSN }} | ||
| JULIA_NUM_THREADS: "1" | ||
| JULIA_PKG_PRECOMPILE_AUTO: "1" | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| with: | ||
| persist-credentials: false | ||
|
|
||
| - name: Verify host toolchain | ||
| run: | | ||
| set -euo pipefail | ||
| command -v julia | ||
| julia --version | ||
|
rmems marked this conversation as resolved.
|
||
| # Job claims Julia 1.12; fail early if runner default drifts. | ||
| julia -e 'VERSION.major == 1 && VERSION.minor == 12 || error("expected Julia 1.12, got $VERSION")' | ||
| nvidia-smi --query-gpu=name,memory.total,driver_version --format=csv,noheader | ||
|
|
||
| - name: Instantiate | ||
| run: julia --project=. -e 'using Pkg; Pkg.instantiate(); Pkg.precompile()' | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
|
|
||
| - name: Verify CUDA.jl in project | ||
| run: | | ||
| set -euo pipefail | ||
| julia --project=. -e ' | ||
| using CUDA | ||
| @assert CUDA.functional() "CUDA.jl reports non-functional device" | ||
| println(CUDA.name(CUDA.device())) | ||
| ' | ||
|
|
||
| - name: Run tests (CPU + GPU) | ||
| run: julia --project=. -e 'using Pkg; Pkg.test()' | ||
|
|
||
| - name: Reclaim GPU memory | ||
| if: always() | ||
| run: | | ||
| julia --project=. -e ' | ||
| using CUDA | ||
| if CUDA.functional() | ||
| CUDA.synchronize() | ||
| GC.gc(true) | ||
| CUDA.reclaim() | ||
| free = CUDA.free_memory() / 1e9 | ||
| total = CUDA.total_memory() / 1e9 | ||
| println("VRAM free/total GB: ", round(free; digits=2), " / ", round(total; digits=2)) | ||
| end | ||
| ' | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.