Add method for formatting (possibly regional) phone numbers in an "absolute" international way.#6
Open
taylorhughes wants to merge 2 commits intormaddy:masterfrom
Open
Add method for formatting (possibly regional) phone numbers in an "absolute" international way.#6taylorhughes wants to merge 2 commits intormaddy:masterfrom
taylorhughes wants to merge 2 commits intormaddy:masterfrom
Conversation
… international" (eg. "(555) 555-5555" -> "+15555555555") numbers by parsing according to the local/specified region and enforcing that the country code is attached at the beginning.
|
This is great. Would love to see this pulled in. |
|
+1 for pull |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need this for the project I'm working on -- you enter 555-555-5555 and I actually want +15555555555 to send to the backend server so we can send a text message. Similarly if you're on a phone in Spain it should return +34555555555 for "555-555-555".
Let me know what you think ... happy to adjust the naming / whatever.