Skip to content

fix memory leaks in sections in librz/bin/p/bin_nso.c - #6836

Open
Syh-Xiong wants to merge 1 commit into
rizinorg:devfrom
Syh-Xiong:fix_memory_leaks_in_sections
Open

Syh-Xiong wants to merge 1 commit into
rizinorg:devfrom
Syh-Xiong:fix_memory_leaks_in_sections

Conversation

@Syh-Xiong

Copy link
Copy Markdown
Contributor

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository.
  • I made sure to follow the project's coding style.
  • I've documented every RZ_API function and struct this PR changes.
  • I've added tests that prove my changes are effective (required for changes to RZ_API).
  • I've updated the Rizin book with the relevant information (if needed).
  • I've used AI tools to generate fully or partially these code changes and I'm sure the changes are not copyrighted by somebody else.

Detailed description
I think the previously allocated ptr should be freed in both branches at lines 325 and 332

...

Test plan

...

Closing issues

...

@codecov

codecov Bot commented Oct 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.35%. Comparing base (4b103d1) to head (18f97e4).

Files with missing lines Patch % Lines
librz/bin/p/bin_nso.c 0.00% 2 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
librz/bin/p/bin_nso.c 53.81% <0.00%> (-0.44%) ⬇️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b103d1...18f97e4. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant