Open
Conversation
Be a bit more verbose in naming, to attempt to improve readability
pearsonryan
approved these changes
Mar 28, 2023
pearsonryan
left a comment
pearsonryan
left a comment
There was a problem hiding this comment.
Looks good most just one description comment I have.
Comment on lines
+65
to
+67
| "joinOn": [ | ||
| "joinTargetTable" | ||
| ] |
Comment on lines
-180
to
+240
| "targetTable": { | ||
| "description": "Target table.", | ||
| "destinationTable": { | ||
| "description": "Destination table where denormalized data will be stored.", |
There was a problem hiding this comment.
I think this makes much more sense to me. We have a table that joins to the targetTable and the denormalized data is put in a destinationTable if I have been reading this correctly.
| "$ref": "#/definitions/column" | ||
| }, | ||
| "default": null, | ||
| "description": "Columns to select from table.", |
There was a problem hiding this comment.
This may be a little confusing of a description here. Maybe something like "Columns to watch for changes. If null then all columns will be watched." just to let people know this field gets used when you only want denorm to pick up changes to specific columns.
There was a problem hiding this comment.
You might include the word "source" as well, as in "source table" or "source data."
mjswensen
approved these changes
Apr 19, 2023
| "destinationKeyExpr": { | ||
| "default": null, | ||
| "description": "SQL expressions for target key values.", | ||
| "description": "SQL expressions for this table's columns that make up the destination table's key columns ([this table name].[column name]).", |
| "description": "Name of table.", | ||
| "title": "Name", | ||
| "type": "string" | ||
| "description": "Columns. Must match columns from destinationQuery select (?)", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Be a bit more verbose in naming, to attempt to improve readability