Repository navigation
feat(pi): trace model requests - #386
Merged
Merged
Conversation
📟 Pip-Boy ·
|
| package (linux-x64-gnu) | @latest |
base | this PR | Δ vs base | packages |
|---|---|---|---|---|---|
@rivet-dev/pi |
372.8 MB | 381.9 MB | 381.9 MB | +8.5 KB (+0.0%) | 220 (0) |
@rivet-dev/sandbox-adapter |
113.8 KB | 114.5 KB | 114.5 KB | 0 | 1 (0) |
@sandbox-agent/cli-shared |
27.2 KB | 27.2 KB | 27.2 KB | 0 | 1 (0) |
@sandbox-agent/persist-indexeddb |
12.4 KB | 12.4 KB | 12.4 KB | 0 | 1 (0) |
@sandbox-agent/persist-postgres |
12.3 KB | 12.3 KB | 12.3 KB | 0 | 1 (0) |
@sandbox-agent/persist-rivet |
12.2 KB | 12.2 KB | 12.2 KB | 0 | 1 (0) |
@sandbox-agent/persist-sqlite |
12.3 KB | 12.3 KB | 12.3 KB | 0 | 1 (0) |
@sandbox-agent/react |
41.6 MB | 41.9 MB | 41.9 MB | 0 | 15 (0) |
acp-http-client |
6.7 MB | 6.7 MB | 6.7 MB | 0 | 3 (0) |
sandbox-agent |
31.0 MB | 31.0 MB | 31.0 MB | 0 | 8 (0) |
🧹 Rust dependencies
Skipped: this PR doesn't change any Rust code or dependencies.
🦀 Binaries
Skipped: this PR doesn't change any Rust code.
⏱ Timing
| job | wall time | slowest step |
|---|---|---|
changes |
23s | checkout · 19s |
zizmor |
20s | checkout · 12s |
footprint |
2m46s | Pack the base · 40s |
⏭ hygiene |
— | skipped |
⏭ native · ${{ matrix.platform }} |
— | skipped |
⏭ self-test |
— | skipped |
report |
30s | setup-node · 12s |
🔭 Full CI trace for this commit
One OpenTelemetry trace of CI and Pip-Boy for dc429ab: every job and step, with the sizes above attached. Run after CI finishes.
pnpm install --frozen-lockfile --filter 'pipboy...'
pnpm --filter pipboy pipboy trace --sha dc429abe4c46a59508f1edb50301b593ea0e34efAdd --otlp <url> to send it to any OTLP/HTTP collector.
Agent instruction: From a rivet-dev/agents checkout, run the commands above, then read the trace file the last command prints. List the slowest jobs and steps and explain where CI time went.
eersnington
force-pushed
the
feat/pi-model-spans
branch
from
November 5, 2026 14:40
a707f6c to
dc429ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ModelRuntimeskips pi-ai'sobserveModelRequest, so defaultpi()actors have no model spans.pi.ai.request,pi.ai.pollchat <model>providergen_ai.provider.namemodelgen_ai.request.modelusage.input+ cache read + cache writegen_ai.usage.input_tokensusage.outputgen_ai.usage.output_tokenscost.totalgen_ai.usage.cost_usdmodels.traceModelRequestswraps the runtime thatcreateActorModelRuntimebuilds and emits Pi's span names, because pi-ai does not exportobserveModelRequest.completeSimplecallsstreamSimpleinsideModelRuntime. Patched methods would give that call two spans.tests/tracing-models.test.tsexpects exactly one span per call, so it fails when Pi fixesModelRuntime. Delete the wrapper then. Users see the same spans.error.type: provider_errorand no error text.This is part 2 of 2 in a stack: