Repository navigation
refactor(react): share Ghostty terminal lifecycle - #379
Closed
vincentkoc wants to merge 1 commit into
Closed
vincentkoc wants to merge 1 commit into
vincentkoc wants to merge 1 commit into
Conversation
Author
|
Closing this draft because Sandbox Agent supports and tests Node 20, while @openclaw/libterminal 0.4.0 declares Node ^22.18.0 || >=24.11.0. The library needs a supported browser-build engine contract before this integration can preserve Rivet’s toolchain. No Node floor change is proposed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed before validation: this integration cannot preserve the current supported toolchain. Sandbox Agent documents Node.js 20+ and tests Node 20 in its checks job; @openclaw/libterminal 0.4.0 declares Node ^22.18.0 || >=24.11.0.
A browser build succeeding on Node 20 would not remove that declared compatibility mismatch. This PR does not change Rivet’s supported Node versions, include the transparency change in #298, or alter the transport contract. No lockfile change was made and no runtime validation is claimed.
Follow-up: establish a supported browser-build engine contract in libterminal before reconsidering this integration.