Repository navigation
fix(native-sidecar): return econnrefused for closed loopback ports - #2085
Merged
Merged
Conversation
A guest TCP connect to a VM loopback port with no listener and no loopbackExemptPorts entry now fails with ECONNREFUSED, as on Linux and in a container with no published ports, instead of EACCES. Wait-for-server loops that retry only on ECONNREFUSED now keep retrying. Both answering paths change: the sidecar connect filter and the kernel loopback check. UDP sends and connects keep their EACCES/EPERM confinement error. The host is still never reached unless the port is exempt.
|
This PR was not deployed automatically as @eersnington does not have access to the Railway project. In order to get automatic PR deploys, please add @eersnington to your workspace on Railway. |
Contributor
📟 Pip-Boy ·
|
| job | wall time | slowest step |
|---|---|---|
⊘ changes |
5m02s | checkout · 4m59s |
zizmor |
10s | checkout · 3s |
report |
29s | checkout · 10s |
⏭ self-test |
— | skipped |
⏭ hygiene |
— | skipped |
⏭ footprint |
— | skipped |
⏭ native · ${{ matrix.platform }} |
— | skipped |
🔭 Full CI trace for this commit
One OpenTelemetry trace of CI and Pip-Boy for c5345ad: every job and step, with the sizes above attached. Run after CI finishes.
pnpm install --frozen-lockfile --filter 'pipboy...'
pnpm --filter pipboy pipboy trace --sha c5345ad9097f645e3212e589b10d3e62890678aaAdd --otlp <url> to send it to any OTLP/HTTP collector.
Agent instruction: From a rivet-dev/agentos checkout, run the commands above, then read the trace file the last command prints. List the slowest jobs and steps and explain where CI time went.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
loopbackExemptPortsentry) now fails withECONNREFUSED, like Linux and a container with no published ports.net.connect(4999, "127.0.0.1"), nothing listeningEACCES: blocked outbound network access … not owned by this VMECONNREFUSED: … no listener … in this VM; host loopback ports require loopbackExemptPortsfetchretry loop waiting for a server to startnetwork-deny-vm-local.test.tsnow expectsECONNREFUSEDfor the host-loopback case. It still asserts the host server receives no request.