Repository navigation
fix(native-sidecar): keep guest writes to API-seeded files - #2070
Merged
Merged
Conversation
Python and WASM/shell writes go only to the kernel VFS, so the VM root shadow kept the bytes from filesystem.writeFile. The next shadow-to-kernel sync saw the two sides differ and copied the stale shadow over the guest edit, and treated a guest rm/recreate as a host deletion. The shadow sync inventory now records a stamp for both sides at each reconciliation. A shadow change reaches the kernel only when the kernel node is unchanged since then, so every guest writer wins without a per-runtime mirror. Seeded bootstrap content still imports as before. Fixes #2022 and #1901. The Python test helper is adapted from #2023 by ankssjain.
|
This PR was not deployed automatically as @eersnington does not have access to the Railway project. In order to get automatic PR deploys, please add @eersnington to your workspace on Railway. |
Contributor
📟 Pip-Boy ·
|
| check | new in this PR | fixed | existing on base |
|---|---|---|---|
| advisories | ✅ 0 | 0 | 25 |
| licenses | ✅ 0 | 0 | 0 |
| sources | ✅ 0 | 0 | 0 |
| bans | ✅ 0 | 0 | 0 |
| unused | ✅ 0 | 0 | 16 |
🦀 Binaries · publish Dockerfiles, --release
Base: main@8cc8f8b, the merge base.
| artifact | npm @latest |
base | this PR | Δ vs base |
|---|---|---|---|---|
agentos-native-sidecar linux-x64-gnu |
143.6 MB | 143.6 MB | 143.8 MB | +206.6 KB (+0.1%) |
⏱ Timing
| job | wall time | slowest step |
|---|---|---|
changes |
34s | checkout · 30s |
zizmor |
12s | checkout · 4s |
hygiene |
54s | checkout · 24s |
native · linux-x64-gnu |
14m00s | Build with the publish Dockerfile · 13m36s |
⏭ self-test |
— | skipped |
⏭ footprint |
— | skipped |
report |
20s | Write the comment and run summary · 7s |
🔭 Full CI trace for this commit
One OpenTelemetry trace of CI and Pip-Boy for b962e79: every job and step, with the sizes above attached. Run after CI finishes.
pnpm install --frozen-lockfile --filter 'pipboy...'
pnpm --filter pipboy pipboy trace --sha b962e79f633dcc9e93bc0265e49602b8d138b6d4Add --otlp <url> to send it to any OTLP/HTTP collector.
Agent instruction: From a rivet-dev/agentos checkout, run the commands above, then read the trace file the last command prints. List the slowest jobs and steps and explain where CI time went.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2022 and #1901. Supersedes #2023.
Edits that Python or the shell made to a file created with
filesystem.writeFilewere silently reverted on the next API read, and a shellrm+ recreate made the API read fail withENOENT.mainrm+ recreateENOENTThe Python test helper is adapted from #2023 by @ankssjain.