refactor(scripts): スクリプトをサブディレクトリ構造に移行する#373
Merged
Merged
Conversation
各スクリプトを専用サブディレクトリに分割し、default.nix と script.sh の固定ファイル名で統一することで可読性と拡張性を高める。 また default.nix では builtins.readDir によるサブディレクトリ自動検出を 導入し、新規スクリプト追加時に default.nix の編集が不要になるようにした。 Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
builtins.filterAttrs は Nix に存在せず CI ビルドが失敗していたため、 builtins.filter と builtins.attrNames を組み合わせた実装に修正する。 Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
modules/scripts/配下の各スクリプトを専用サブディレクトリに分割し、ファイル名をdefault.nix/script.shに統一したswitch-branch-with-refreshはインライン記述だったシェルスクリプトをscript.shに切り出して参照する形に変更したdefault.nixでbuiltins.readDirによるサブディレクトリ自動検出を導入し、新規スクリプト追加時にdefault.nixの編集が不要になった確認事項
nixfmt/shellcheckいずれも問題なしhome-manager build --flake .#testuserでビルド成功を確認済み🤖 Generated with Claude Code