This repository was archived by the owner on Nov 28, 2025. It is now read-only.
Reflect that the CSR already exists in the Instruction Set Manual.#138
Open
radimkrcmar wants to merge 5 commits intoriscvarchive:masterfrom
Open
Reflect that the CSR already exists in the Instruction Set Manual.#138radimkrcmar wants to merge 5 commits intoriscvarchive:masterfrom
radimkrcmar wants to merge 5 commits intoriscvarchive:masterfrom
Conversation
The same note could be added to all new CSRs. Other CRSs don't mention it because implementations are already given maximal freedom. How the CSR is implemented is irrelevant to M-mode software. The best UD can do is to leave the implementation details unspecified. Implementers will know how to deal with it. Signed-off-by: Radim Krčmář <rkrcmar@ventanamicro.com>
The ISM defines the mconfigptr CSR as read-only. Signed-off-by: Radim Krčmář <rkrcmar@ventanamicro.com>
The first sentence is not correct, because the CSR can also be zero, in which case it doesn't provide the base-address. Do not complicate the definition here and just refer to the ISM as it provides all relevant information about the mconfigptr CSR. Signed-off-by: Radim Krčmář <rkrcmar@ventanamicro.com>
The mconfigptr CSR is already ratified and imposes some extra requirements on the base address. Signed-off-by: Radim Krčmář <rkrcmar@ventanamicro.com>
Explicitly mentioning the logical conclusion can make the specification a bit easier to interpret. Signed-off-by: Radim Krčmář <rkrcmar@ventanamicro.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for each change is in the commit messages.