replace DataFrame.append for pandas.concat for pandas 2 compatibility#309
Open
fwaibl wants to merge 5 commits intorinikerlab:mainfrom
Open
replace DataFrame.append for pandas.concat for pandas 2 compatibility#309fwaibl wants to merge 5 commits intorinikerlab:mainfrom
fwaibl wants to merge 5 commits intorinikerlab:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #309 +/- ##
==========================================
+ Coverage 54.40% 54.94% +0.54%
==========================================
Files 93 93
Lines 14349 14339 -10
==========================================
+ Hits 7806 7879 +73
+ Misses 6543 6460 -83
Flags with carried forward coverage won't be shown. Click here to find out more.
|
added 2 commits
July 20, 2023 09:48
* DataFrame.append was previously used in noe_output.py. Replace it for pd.concat * Adds unit tests for the NOE class in noe_output.py * Simplifies the load_file function
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed that the tests are currently failing due to an incompatibility with pandas version 2. The solution is to use pd.concat instead of DataFrame.append.
Todos
Similar problems might arise in other files, but it is hard to find them reliably. I found the object NOE_violations in files/otherfiles/noe_output.py