replica exchange simulation submission + minor reeds tweaks#288
Open
candidechamp wants to merge 6 commits intomainfrom
Open
replica exchange simulation submission + minor reeds tweaks#288candidechamp wants to merge 6 commits intomainfrom
candidechamp wants to merge 6 commits intomainfrom
Conversation
added 4 commits
April 11, 2022 10:43
Codecov Report
@@ Coverage Diff @@
## main #288 +/- ##
==========================================
- Coverage 54.14% 54.12% -0.02%
==========================================
Files 93 93
Lines 14285 14279 -6
==========================================
- Hits 7734 7728 -6
Misses 6551 6551
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Collaborator
Author
|
@MTLehner I think you can merge the code now (you probably want to checkout and submit a quick calculation just to make sure everything is fine on your end). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I reimplemented (and re-tested) the changes in #222 (as I didn't want to have trouble with merge conflicts, although they all seemed super minor and would have been easily fixed).
The code in here is essentially the same as in #222 with the exception of some
imdrelated functions, where I simplified a call tostr2bool(previously was put in an if, else block based on input given to function, which already happens in the function).To do
Status
PS: Please don't delete the pygromos3_for_reeds branch after merge. I would like to keep this branch in parallel at all times (and probably also have a "release" for it so that there is an easily accessible version for RE-EDS users once I have implemented all I need to).