Repository navigation
Temperatures in °F or °C: Automatic follows the household's country, or Settings says - #5
Open
pathik-vyas wants to merge 7 commits into
Open
pathik-vyas wants to merge 7 commits into
pathik-vyas wants to merge 7 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Riley, thank you for Gingham. It's lovely on the wall. I'd like the weather in Celsius, and there was no way to change it, so this adds one.
What it does
A new Temperature setting in the frame's Settings, under Appearance, next to Clock: Automatic / °F / °C.
How
deg()helper indist/app.js.settings.jsacceptstemperature: 'auto' | 'F' | 'C', defaulting to'auto'. Anything else is ignored, like the other settings.Tests
test/settings.test.js: the setting's default, accepted values and persistence.test/wall.test.js: US and unknown-country households stay in °F, a GB household is in °C everywhere on the wall, Settings overrides the country both ways, and the three choices appear.test/updates-server.test.js: addedtemperatureto the 0.1.0 upgrade test, as with the earlier settings.npm run check && npm testpasses: 212 tests.Happy to change anything, such as the labels, where it sits in Settings, or the country list.
🤖 Generated with Claude Code
https://claude.ai/code/session_01QMXEQa7MreWUVb5BaDr9s9