Repository navigation
fix(release): emit postflight_steps in the Homebrew cask - #261
Merged
Merged
Conversation
Homebrew 7 deprecated cask `postflight` blocks and warns on every `brew upgrade`/`cleanup`. GoReleaser renders `hooks.post.install` as a `postflight` block, so the quarantine strip now goes in through `custom_block` as a `postflight_steps` block instead. Also drop `url.verified`, which GoReleaser deprecated after Homebrew did.
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Homebrew 7 deprecated cask
postflightblocks, so everybrew upgrade/brew cleanupprints:GoReleaser renders
hooks.post.installas apostflightblock (its current template still does), so the quarantine strip now goes in throughcustom_blockas apostflight_stepsblock. Steps blocks only take literal paths, so it useschdir: "."(resolved against the staged path) rather than#{staged_path}.Also drops
url.verified, which GoReleaser deprecated after Homebrew did.goreleaser checkis now clean.Verified locally:
brew stylepasses the new block and flags the old one.The tap picks this up on the next release.
Summary by CodeRabbit
rr, which can help prevent macOS from blocking the executable after installation.