Skip to content

fix(release): emit postflight_steps in the Homebrew cask - #261

Merged
rileyhilliard merged 1 commit into
mainfrom
fix/cask-postflight-steps
Oct 6, 2026
Merged

rileyhilliard merged 1 commit into
mainfrom
fix/cask-postflight-steps

Conversation

@rileyhilliard

@rileyhilliard rileyhilliard commented Oct 6, 2026 •

Copy link
Copy Markdown
Owner

Homebrew 7 deprecated cask postflight blocks, so every brew upgrade/brew cleanup prints:

Warning: Calling postflight is deprecated! Use postflight_steps instead. Please report this issue to the rileyhilliard/homebrew-tap tap ... Casks/rr.rb:36

GoReleaser renders hooks.post.install as a postflight block (its current template still does), so the quarantine strip now goes in through custom_block as a postflight_steps block. Steps blocks only take literal paths, so it uses chdir: "." (resolved against the staged path) rather than #{staged_path}.

Also drops url.verified, which GoReleaser deprecated after Homebrew did. goreleaser check is now clean.

Verified locally:

  • brew style passes the new block and flags the old one.
  • A GoReleaser snapshot renders the block as expected.
  • Swapping the rendered cask into the local tap and reinstalling 0.29.2 gives no warning, no quarantine attribute, and a working binary. A deliberately failing step in the same spot fails the install, so the step does run.

The tap picks this up on the next release.

Summary by CodeRabbit

  • Bug Fixes
    • macOS installations now clear the quarantine attribute from rr, which can help prevent macOS from blocking the executable after installation.
    • The Homebrew cask’s post-install behavior has been updated to perform this step.

Homebrew 7 deprecated cask `postflight` blocks and warns on every
`brew upgrade`/`cleanup`. GoReleaser renders `hooks.post.install` as a
`postflight` block, so the quarantine strip now goes in through
`custom_block` as a `postflight_steps` block instead.

Also drop `url.verified`, which GoReleaser deprecated after Homebrew
did.
@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository: rileyhilliard/rr/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 794f415e-1a5a-441c-90bf-f683eb0d46cf
📥 Commits

Reviewing files that changed from the base of the PR and between 743067f and 1eb19f4.

📒 Files selected for processing (1)
  • .goreleaser.yaml
 __________________________________________________
< Deploying the charm offensive against your bugs. >
 --------------------------------------------------
  \
   \   \
        \ /\
        ( )
      .( o ).
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@rileyhilliard
rileyhilliard merged commit efe93f7 into main Oct 6, 2026
8 of 9 checks passed
@rileyhilliard
rileyhilliard deleted the fix/cask-postflight-steps branch October 6, 2026 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant