Open
Conversation
richo
reviewed
Aug 4, 2018
| go reaper.run() | ||
|
|
||
| setupAndServe() | ||
| port := 1234 |
Owner
There was a problem hiding this comment.
Is this stray? Is there some weird scoping thing I don't understand?
Collaborator
Author
There was a problem hiding this comment.
I should have been clearer - I wanted to make it easier to change the server port, since 8000 (goji's default) is often already in use by other programs. One day this var will become a config or command line value.
Owner
There was a problem hiding this comment.
oh, I just meant I think this shadows the port argument to this function? but maybe I'm confused.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r? @richo
make example-client-ruby-buildfor building Ruby example