Skip to content

feat(holder): add configurable holder-edge spacing - #61

Merged
richardsolomou merged 1 commit into
mainfrom
ras-code/add-holder-edge-spacing
Aug 31, 2026
Merged

feat(holder): add configurable holder-edge spacing#61
richardsolomou merged 1 commit into
mainfrom
ras-code/add-holder-edge-spacing

Conversation

@richardsolomou

Copy link
Copy Markdown
Owner

Problem

Holder slot spacing did not control the clearance between slot recesses and the holder edge, which could leave slots too close to the perimeter or require more module space than expected.

Changes

  • Add configurable holder-edge spacing with a default of half the miniature spacing.
  • Preserve the default relationship when miniature spacing changes until edge spacing is customized.
  • Account for edge spacing during holder packing, capacity limits, and module sizing.
  • Migrate saved workspaces to the new setting and document the behavior in the README.
  • Add unit and end-to-end coverage for defaults, customization, packing, and migration.

Risk

Low. Holder layouts and persisted workspace loading are affected; the change can be rolled back with the existing commit or release rollback.

Verification

  • Added holder geometry unit tests for defaults, edge clearance, and additional column selection.
  • Added workspace migration coverage for legacy saved settings.
  • Added end-to-end coverage for default, customized, and reset edge spacing behavior.

Checklist

  • Tests cover new or changed behavior where practical.
  • Geometry changes are checked against a real export, not just the preview.
  • User-facing behavior is documented in the README.

- Default edge spacing to half the miniature spacing
- Migrate saved workspaces to the new setting
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 31, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
basekit 7370713 Commit Preview URL

Branch Preview URL
Aug 31 2026, 12:53 PM

@richardsolomou
richardsolomou merged commit 6af57fe into main Aug 31, 2026
4 checks passed
@richardsolomou
richardsolomou deleted the ras-code/add-holder-edge-spacing branch August 31, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant